> "Mark" == Mark Dilger writes:
Mark> I tried briefly to download this project from pgfoundry without
Mark> success. Do you have a copy of the relevant code where you can
Mark> see how this gets defined, and can you include it in a reply?
I have a backup of the CVS from the pgfoundry vers
On 10/15/19 5:23 AM, Andrew Gierth wrote:
"Mark" == Mark Dilger writes:
>> +#ifdef HSTORE_IS_HSTORE_NEW
Mark> Checking the current sources, git history, and various older
Mark> commits, I did not find where HSTORE_IS_HSTORE_NEW was ever
Mark> defined.
In contrib/hstore, it never w
On 2019-10-14 17:12, Mark Dilger wrote:
> The check on HSTORE_IS_HSTORE_NEW goes back at least as far as 2006,
> suggesting it was needed for migrating from some version pre-9.0, making
> me wonder if anybody would need this in the field. Should we drop
> support for this? I don't have a stron
On 2019-10-13 21:25, Peter Eisentraut wrote:
> During the cleanup of the _MSC_VER versions (commit
> 38d8dce61fff09daae0edb6bcdd42b0c7f10ebcd), I found it useful to use
> -Wundef, but that resulted in a bunch of gratuitous warnings. Here is a
> patch to fix those. Most of these are just stylistic
> "Mark" == Mark Dilger writes:
>> +#ifdef HSTORE_IS_HSTORE_NEW
Mark> Checking the current sources, git history, and various older
Mark> commits, I did not find where HSTORE_IS_HSTORE_NEW was ever
Mark> defined.
In contrib/hstore, it never was.
The current version of contrib/hstore had
Peter Eisentraut writes:
> During the cleanup of the _MSC_VER versions (commit
> 38d8dce61fff09daae0edb6bcdd42b0c7f10ebcd), I found it useful to use
> -Wundef, but that resulted in a bunch of gratuitous warnings. Here is a
> patch to fix those. Most of these are just stylistic cleanups, but the
On 10/13/19 12:25 PM, Peter Eisentraut wrote:
diff --git a/contrib/hstore/hstore_compat.c b/contrib/hstore/hstore_compat.c
index 1d4e7484e4..d75e9cb23f 100644
--- a/contrib/hstore/hstore_compat.c
+++ b/contrib/hstore/hstore_compat.c
@@ -299,7 +299,7 @@ hstoreUpgrade(Datum orig)
if (valid
Sep 2019 22:50:05 +0200
Subject: [PATCH] Fix most -Wundef warnings
In some cases #if was used instead of #ifdef in an inconsistent style.
Cleaning this up also helps when analyzing cases like
38d8dce61fff09daae0edb6bcdd42b0c7f10ebcd where this makes a
difference.
There are no behavior changes here,
