Re: Fix incorrect comment reference

2023-09-29 Thread James Coleman
On Fri, Sep 29, 2023 at 2:26 PM Bruce Momjian wrote: > > On Mon, Jan 23, 2023 at 06:42:45PM -0500, James Coleman wrote: > > On Mon, Jan 23, 2023 at 4:07 PM James Coleman wrote: > > > > > > On Mon, Jan 23, 2023 at 3:41 PM Robert Haas wrote: > > > > > > > > On Mon, Jan 23, 2023 at 3:19 PM James Co

Re: Fix incorrect comment reference

2023-09-29 Thread Bruce Momjian
On Mon, Jan 23, 2023 at 06:42:45PM -0500, James Coleman wrote: > On Mon, Jan 23, 2023 at 4:07 PM James Coleman wrote: > > > > On Mon, Jan 23, 2023 at 3:41 PM Robert Haas wrote: > > > > > > On Mon, Jan 23, 2023 at 3:19 PM James Coleman wrote: > > > > On Mon, Jan 23, 2023 at 1:26 PM Robert Haas

Re: Fix incorrect comment reference

2023-01-23 Thread James Coleman
On Mon, Jan 23, 2023 at 4:07 PM James Coleman wrote: > > On Mon, Jan 23, 2023 at 3:41 PM Robert Haas wrote: > > > > On Mon, Jan 23, 2023 at 3:19 PM James Coleman wrote: > > > On Mon, Jan 23, 2023 at 1:26 PM Robert Haas wrote: > > > > On Mon, Jan 23, 2023 at 8:31 AM James Coleman wrote: > > > >

Re: Fix incorrect comment reference

2023-01-23 Thread James Coleman
On Mon, Jan 23, 2023 at 3:41 PM Robert Haas wrote: > > On Mon, Jan 23, 2023 at 3:19 PM James Coleman wrote: > > On Mon, Jan 23, 2023 at 1:26 PM Robert Haas wrote: > > > On Mon, Jan 23, 2023 at 8:31 AM James Coleman wrote: > > > > See the attached for a simple comment fix -- the referenced > > >

Re: Fix incorrect comment reference

2023-01-23 Thread Robert Haas
On Mon, Jan 23, 2023 at 3:19 PM James Coleman wrote: > On Mon, Jan 23, 2023 at 1:26 PM Robert Haas wrote: > > On Mon, Jan 23, 2023 at 8:31 AM James Coleman wrote: > > > See the attached for a simple comment fix -- the referenced > > > generate_useful_gather_paths call isn't in grouping_planner i

Re: Fix incorrect comment reference

2023-01-23 Thread James Coleman
On Mon, Jan 23, 2023 at 1:26 PM Robert Haas wrote: > > On Mon, Jan 23, 2023 at 8:31 AM James Coleman wrote: > > See the attached for a simple comment fix -- the referenced > > generate_useful_gather_paths call isn't in grouping_planner it's in > > apply_scanjoin_target_to_paths. > > The intended

Re: Fix incorrect comment reference

2023-01-23 Thread Robert Haas
On Mon, Jan 23, 2023 at 8:31 AM James Coleman wrote: > See the attached for a simple comment fix -- the referenced > generate_useful_gather_paths call isn't in grouping_planner it's in > apply_scanjoin_target_to_paths. The intended reading of the comment is not clear. Is it telling you to look at

Fix incorrect comment reference

2023-01-23 Thread James Coleman
Hello, See the attached for a simple comment fix -- the referenced generate_useful_gather_paths call isn't in grouping_planner it's in apply_scanjoin_target_to_paths. Thanks, James Coleman v1-0001-Fixup-incorrect-comment.patch Description: Binary data