On 2022-Jul-15, Thomas Munro wrote:
> On Mon, Jul 11, 2022 at 9:45 PM Kyotaro Horiguchi
> wrote:
> > So, for starters, I compiled the whole tree with -Wshadow=local. and I
> > saw many warnings with it. At a glance all of them are reasonably
> > "fixed" but I don't think it is what we want...
>
On Mon, Jul 11, 2022 at 9:45 PM Kyotaro Horiguchi
wrote:
> At Mon, 11 Jul 2022 01:45:16 -0400, Tom Lane wrote in
> > Kyotaro Horiguchi writes:
> > > At Sat, 9 Jul 2022 21:53:31 -0300, Ranier Vilela
> > > wrote in
> > >> 528 |entry = (PendingUnlinkEntry *) lfirst(cell);
> >
> > > Actually,
At Mon, 11 Jul 2022 01:45:16 -0400, Tom Lane wrote in
> [ cc'ing Thomas, whose code this seems to be ]
>
> Kyotaro Horiguchi writes:
> > At Sat, 9 Jul 2022 21:53:31 -0300, Ranier Vilela
> > wrote in
> >> 528 |entry = (PendingUnlinkEntry *) lfirst(cell);
>
> > Actually, I already see the
[ cc'ing Thomas, whose code this seems to be ]
Kyotaro Horiguchi writes:
> At Sat, 9 Jul 2022 21:53:31 -0300, Ranier Vilela wrote
> in
>> sync.c: In function ¡RememberSyncRequest¢:
>> sync.c:528:10: warning: assignment to ¡PendingFsyncEntry *¢ {aka ¡struct
>> *¢} from incompatible pointer typ
At Sat, 9 Jul 2022 21:53:31 -0300, Ranier Vilela wrote in
> sync.c: In function ‘RememberSyncRequest’:
> sync.c:528:10: warning: assignment to ‘PendingFsyncEntry *’ {aka ‘struct
> *’} from incompatible pointer type ‘PendingUnlinkEntry *’ {aka
> ‘struct *’} [-Wincompatible-pointer-types]
> 528
Hi,
In one of my compilations of Postgres, I noted this warning from gcc.
gcc -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type
-Wformat-security -fno-strict-aliasing -fwrapv
