Re: Fix foreign key constraint check for partitioned tables

2019-04-07 Thread Alvaro Herrera
On 2019-Apr-06, Tom Lane wrote: > Hadi Moshayedi writes: > > This patch also changed the output of some of tests, i.e. previously > > foreign key constraint failures errored on the partitioned table itself, > > but now it shows the child table's name in the error message. I hope it is > > ok. >

Re: Fix foreign key constraint check for partitioned tables

2019-04-06 Thread Tom Lane
Hadi Moshayedi writes: > [ fix-foreign-key-check.patch ] Pushed with some adjustments, as discussed over at https://postgr.es/m/19030.1554574...@sss.pgh.pa.us > This patch also changed the output of some of tests, i.e. previously > foreign key constraint failures errored on the partitioned table

Re: Fix foreign key constraint check for partitioned tables

2019-03-26 Thread Hadi Moshayedi
Posted this at the commitfest tool: https://commitfest.postgresql.org/23/2075/ >

Re: Fix foreign key constraint check for partitioned tables

2019-03-25 Thread Hadi Moshayedi
Hello Edmund, Thanks for the review. > I was a bit curious about the need for "set role" in the reproduction, > but I see that it's because RI_Initial_Check does some checks to see > if a simple SELECT can be used, and one of the checks is for basic > table permissions. > I think to reproduce t

Re: Fix foreign key constraint check for partitioned tables

2019-03-23 Thread Edmund Horner
On Sat, 23 Mar 2019 at 12:01, Hadi Moshayedi wrote: > Yesterday while doing some tests, I noticed that the following doesn't work > properly: > > create role test_role with login; > create table ref(a int primary key); > grant references on ref to test_role; > set role test_role; > create table t

Fix foreign key constraint check for partitioned tables

2019-03-22 Thread Hadi Moshayedi
Yesterday while doing some tests, I noticed that the following doesn't work properly: create role test_role with login; create table ref(a int primary key); grant references on ref to test_role; set role test_role; create table t1(a int, b int) partition by list (a); alter table t1 add constraint