Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2023-04-26 Thread Dimos Stamatakis
Hi hackers, I was wondering whether there are any updates on the bug in visibility check introduced in version 14.5. Many thanks, Dimos [ServiceNow]

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-29 Thread Dimos Stamatakis
[External Email] On 2022-Nov-25, Dimos Stamatakis wrote: > So does this mean there is no race condition in this case and that > this error is redundant? No, it means I believe a bug exists but that I haven't spent enough time on it to understand what it is. Great! Please keep me posted and le

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-25 Thread Alvaro Herrera
On 2022-Nov-25, Dimos Stamatakis wrote: > So does this mean there is no race condition in this case and that > this error is redundant? No, it means I believe a bug exists but that I haven't spent enough time on it to understand what it is. Please do not top-post. https://wiki.postgresql.org/wik

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-25 Thread Dimos Stamatakis
Subject: Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency [External Email] On 2022-Nov-24, Alvaro Herrera wrote: > On 2022-Nov-24, Dimos Stamatakis wrote: > > > rmgr: MultiXact len (rec/tot): 54/ 54, tx: 248477, lsn: 0/66DB82A8, prev > > 0/66DB8260, d

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-24 Thread Alvaro Herrera
On 2022-Nov-24, Alvaro Herrera wrote: > On 2022-Nov-24, Dimos Stamatakis wrote: > > > rmgr: MultiXact len (rec/tot): 54/54, tx: 248477, lsn: > > 0/66DB82A8, prev 0/66DB8260, desc: CREATE_ID 133 offset 265 nmembers 2: > > 248477 (nokeyupd) 248500 (keysh) > > rmgr: Heaplen (

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-24 Thread Alvaro Herrera
On 2022-Nov-24, Dimos Stamatakis wrote: > Thanks for your feedback! > I applied the patch to print more information about the error. Here’s what I > got: > > 2022-11-23 20:33:03 UTC [638 test_database]: [5458] ERROR: new multixact has > more than one updating member: 0 2[248477 (nokeyupd), 248

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-24 Thread Alvaro Herrera
On 2022-Nov-23, Peter Geoghegan wrote: > On Wed, Nov 23, 2022 at 2:54 AM Alvaro Herrera > wrote: > > Something like the attached. It would result in output like this: > > WARNING: new multixact has more than one updating member: 0 2[17378 > > (keysh), 17381 (nokeyupd)] > > > > Then it should

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-23 Thread Peter Geoghegan
On Wed, Nov 23, 2022 at 2:54 AM Alvaro Herrera wrote: > Something like the attached. It would result in output like this: > WARNING: new multixact has more than one updating member: 0 2[17378 (keysh), > 17381 (nokeyupd)] > > Then it should be possible to trace (in pg_waldump output) the > opera

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-23 Thread Alvaro Herrera
On 2022-Nov-23, Alvaro Herrera wrote: > I suggest that we could improve that elog() so that it includes the > members of the multixact in question, which could help us better > understand what is going on. Something like the attached. It would result in output like this: WARNING: new multixact

Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-23 Thread Alvaro Herrera
Hello Dimos On 2022-Nov-22, Dimos Stamatakis wrote: > When running tpcc on sysbench with high concurrency (96 threads, scale > factor 5) we realized that a fix for visibility check (introduced in > PG-14.5) causes sysbench to fail in 1 out of 70 runs. > The error is the following: > > SQL error,

Fix for visibility check on 14.5 fails on tpcc with high concurrency

2022-11-22 Thread Dimos Stamatakis
Hi hackers, When running tpcc on sysbench with high concurrency (96 threads, scale factor 5) we realized that a fix for visibility check (introduced in PG-14.5) causes sysbench to fail in 1 out of 70 runs. The error is the following: SQL error, errno = 0, state = 'XX000': new multixact has more