On Oct 9 2025, at 11:28 am, Tom Lane wrote:
> Nathan Bossart writes:
>> Just curious, what compiler/version is this? I skimmed the buildfarm
>> a bit
>> but didn't find any such warnings.
>
> My warning-scraping script found
>
> arowana | 2025-10-07 04:51:16 | nodeWindowAgg.c:3723:8:
On Thu, Oct 09, 2025 at 09:41:15AM -0500, Nathan Bossart wrote:
> On Thu, Oct 09, 2025 at 10:21:23AM -0400, Greg Burd wrote:
>> ‘WinGetFuncArgInPartition’:../src/backend/executor/nodeWindowAgg.c:3809:33:
>> warning:‘notnull_relpos’ may be used uninitialized
>> [-Wmaybe-uninitialized] 3809 |
Greg Burd writes:
> To calm the compiler's nerves this patch moves the initialization of
> notnull_relpos to later in the function.
I was seeing the same warning for "forward" in the buildfarm,
so I moved all of these initializations down. Otherwise,
looks like we independently invented the same
Nathan Bossart writes:
> Just curious, what compiler/version is this? I skimmed the buildfarm a bit
> but didn't find any such warnings.
My warning-scraping script found
arowana | 2025-10-07 04:51:16 | nodeWindowAgg.c:3723:8: warning:
'forward' may be used uninitialized in this function
On Oct 9 2025, at 10:45 am, Nathan Bossart wrote:
> On Thu, Oct 09, 2025 at 09:41:15AM -0500, Nathan Bossart wrote:
>> On Thu, Oct 09, 2025 at 10:21:23AM -0400, Greg Burd wrote:
>>> ‘WinGetFuncArgInPartition’:../src/backend/executor/nodeWindowAgg.c:3809:33:
>>> warning:‘notnull_relpos’ may be u
On Thu, Oct 09, 2025 at 10:21:23AM -0400, Greg Burd wrote:
> ‘WinGetFuncArgInPartition’:../src/backend/executor/nodeWindowAgg.c:3809:33:
> warning:‘notnull_relpos’ may be used uninitialized
> [-Wmaybe-uninitialized] 3809 | } while (notnull_offset <
> notnull_relpos); |
Hello,
This is a minor change that avoids a "maybe uninitialized" warning that
I've been seeing since:
25a30bbd423 Add IGNORE NULLS/RESPECT NULLS option to Window functions.
src/backend/postgres_lib.a.p/executor_nodeWindowAgg.c.o../src/backend/executor/nodeWindowAgg.c:
In function
‘WinGetFuncArgI
