Re: Fix doc bug in logical replication.

2019-07-08 Thread Peter Eisentraut
On 2019-06-27 18:50, Tomas Vondra wrote: >> Whether we *want* to document that it works, documenting that it >> doesn't work when it does can't be the right answer. If you want to >> couch the language to leave the door open that we may not support this >> the same way in the future I wouldn't be o

Re: Fix doc bug in logical replication.

2019-06-27 Thread Dave Cramer
On Thu, 27 Jun 2019 at 14:20, Tomas Vondra wrote: > On Thu, Jun 27, 2019 at 01:46:47PM -0400, Dave Cramer wrote: > >On Thu, 27 Jun 2019 at 12:50, Tomas Vondra > >wrote: > > > >> On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: > >> >On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut >

Re: Fix doc bug in logical replication.

2019-06-27 Thread Tomas Vondra
On Thu, Jun 27, 2019 at 01:46:47PM -0400, Dave Cramer wrote: On Thu, 27 Jun 2019 at 12:50, Tomas Vondra wrote: On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: >On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut > wrote: >> >> On 2019-04-12 19:52, Robert Treat wrote: >> > It is clea

Re: Fix doc bug in logical replication.

2019-06-27 Thread Dave Cramer
On Thu, 27 Jun 2019 at 12:50, Tomas Vondra wrote: > On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: > >On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut > > wrote: > >> > >> On 2019-04-12 19:52, Robert Treat wrote: > >> > It is clear to me that the docs are wrong, but I don't see any

Re: Fix doc bug in logical replication.

2019-06-27 Thread Tomas Vondra
On Sun, Jun 23, 2019 at 10:26:47PM -0400, Robert Treat wrote: On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut wrote: On 2019-04-12 19:52, Robert Treat wrote: > It is clear to me that the docs are wrong, but I don't see anything > inherently incorrect about the code itself. Do you have suggest

Re: Fix doc bug in logical replication.

2019-06-23 Thread Robert Treat
On Sun, Jun 23, 2019 at 1:25 PM Peter Eisentraut wrote: > > On 2019-04-12 19:52, Robert Treat wrote: > > It is clear to me that the docs are wrong, but I don't see anything > > inherently incorrect about the code itself. Do you have suggestions > > for how you would like to see the code comments i

Re: Fix doc bug in logical replication.

2019-06-23 Thread Peter Eisentraut
On 2019-04-12 19:52, Robert Treat wrote: > It is clear to me that the docs are wrong, but I don't see anything > inherently incorrect about the code itself. Do you have suggestions > for how you would like to see the code comments improved? The question is perhaps whether we want to document that

Re: Fix doc bug in logical replication.

2019-04-12 Thread Robert Treat
On Mon, Apr 8, 2019 at 7:19 PM Euler Taveira wrote: > > Em seg, 8 de abr de 2019 às 19:38, Robert Treat escreveu: > > > > I noticed that the docs currently state "A different order of columns > > in the target table is allowed, but the column types have to match." > > This is untrue, as you can r

Re: Fix doc bug in logical replication.

2019-04-08 Thread Euler Taveira
Em seg, 8 de abr de 2019 às 19:38, Robert Treat escreveu: > > I noticed that the docs currently state "A different order of columns > in the target table is allowed, but the column types have to match." > This is untrue, as you can replicate between any two data types as > long as the data can be

Fix doc bug in logical replication.

2019-04-08 Thread Robert Treat
Howdy folks, I noticed that the docs currently state "A different order of columns in the target table is allowed, but the column types have to match." This is untrue, as you can replicate between any two data types as long as the data can be coerced into the right format on the subscriber. Attach