Re: Fix compiler warnings on 64-bit Windows

2020-02-21 Thread Peter Eisentraut
On 2020-02-20 17:24, Tom Lane wrote: =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= writes: On Mon, Feb 17, 2020 at 4:52 PM Tom Lane wrote: Anyway, I'll have a go at updating gaur to use 4.5.x. There is a sane-looking stdint.h on my second-oldest dinosaur, prairiedog. Don't know about th

Re: Fix compiler warnings on 64-bit Windows

2020-02-20 Thread Tom Lane
=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= writes: > On Mon, Feb 17, 2020 at 4:52 PM Tom Lane wrote: >> Anyway, I'll have a go at updating gaur to use 4.5.x. There is a >> sane-looking stdint.h on my second-oldest dinosaur, prairiedog. >> Don't know about the situation on Windows, though

Re: Fix compiler warnings on 64-bit Windows

2020-02-17 Thread Juan José Santamaría Flecha
On Mon, Feb 17, 2020 at 4:52 PM Tom Lane wrote: > > Anyway, I'll have a go at updating gaur to use 4.5.x. There is a > sane-looking stdint.h on my second-oldest dinosaur, prairiedog. > Don't know about the situation on Windows, though. We might want > to take a close look at NetBSD, too, based

Re: Fix compiler warnings on 64-bit Windows

2020-02-17 Thread Tom Lane
I wrote: > Ooops. Poking around, it looks like this version of gcc has brought its > own stdbool.h, but not stdint.h: > ... > Kind of annoying. Perhaps more recent gcc versions fixed that? Here we go, in the gcc 4.5.x release notes: GCC now ensures that a C99-conforming is present on most

Re: Fix compiler warnings on 64-bit Windows

2020-02-17 Thread Tom Lane
Peter Eisentraut writes: > On 2020-02-14 15:52, Tom Lane wrote: >> BTW: I'm still concerned about the possibility of the C library being >> less than C99. The model that was popular back then, and which still >> exists on e.g. gaur, was that you could install a C99 *compiler* on >> a pre-C99 syst

Re: Fix compiler warnings on 64-bit Windows

2020-02-17 Thread Peter Eisentraut
On 2020-02-14 15:52, Tom Lane wrote: Yeah, I think that the C99 requirement has obsoleted a number of configure tests and related hackery in c.h. We just haven't got round to cleaning that up yet. BTW: I'm still concerned about the possibility of the C library being less than C99. The model th

Re: Fix compiler warnings on 64-bit Windows

2020-02-14 Thread Tom Lane
Peter Eisentraut writes: > On 2020-02-13 16:19, Tom Lane wrote: >> According to C99 and POSIX, intptr_t should be provided by ... >> now that we're requiring C99, can we get away with just #include'ing >> that directly in these test files? > I think in the past we were worried about the C librar

Re: Fix compiler warnings on 64-bit Windows

2020-02-14 Thread Peter Eisentraut
On 2020-02-13 16:19, Tom Lane wrote: According to C99 and POSIX, intptr_t should be provided by ... now that we're requiring C99, can we get away with just #include'ing that directly in these test files? I think in the past we were worried about the C library not being fully C99. But the bui

Re: Fix compiler warnings on 64-bit Windows

2020-02-13 Thread Tom Lane
Peter Eisentraut writes: > GCC reports various instances of > warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > warning: cast from pointer to integer of different size > [-Wpointer-to-int-cast] > in ECPG test files. This is because void* and long are

Fix compiler warnings on 64-bit Windows

2020-02-13 Thread Peter Eisentraut
adfcbc45cbe968d1a1230bce7a2891e75038d84 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 13 Feb 2020 15:02:45 +0100 Subject: [PATCH] Fix compiler warnings on 64-bit Windows GCC reports various instances of warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] wa