On Sun, Dec 22, 2024 at 11:15:31PM -0500, Tom Lane wrote:
> WFM
Okay, done this way then, thanks.
--
Michael
signature.asc
Description: PGP signature
> The saved hooks are not here to readjust the stack based on a reload,
> just to make sure that the existing paths loaded are all taken. I
> would just remove the "in case of unload" part for the last three, and
> "unload" for the first one. Thoughts?
LGTM.
--
Regards,
ChangAo Chen
Michael Paquier writes:
> While on it, I think that we should adjust all these ones too:
> contrib/sepgsql/hooks.c: * Module load/unload callback
> contrib/auto_explain/auto_explain.c:/* Saved hook values in case of
> unload */
> contrib/passwordcheck/passwordcheck.c:/* Saved hook value in case of
On Sun, Dec 22, 2024 at 10:50:47PM -0500, Tom Lane wrote:
> Michael Paquier writes:
>> Right. This comment is misleading.
>
> I think it was once correct, decades ago. Obviously we missed
> fixing it when we ripped out the unload functionality.
This was recent enough, and easy to miss.
>> -
Michael Paquier writes:
> On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
> * This function loads a shlib file without looking up any particular
> * function in it. If the same shlib has previously been loaded,
> - * unload and reload it.
> + * we don't load it again.
> Right. This
On Mon, Dec 23, 2024 at 10:58:49AM +0800, cca5507 wrote:
> /* If the same shlib has previously been loaded, unload and reload it. */
>
> But we currently don't support to unload a shlib.
* This function loads a shlib file without looking up any particular
* function in it. If the same shlib
Hi,
The comment in load_file():
/* If the same shlib has previously been loaded, unload and reload it. */
But we currently don't support to unload a shlib.
Here is a small patch to fix it.
--
Regards,
ChangAo Chen
0001-Fix-a-wrong-comment-in-load_file.patch
Description: Binary data
