Re: Fix a comment error in logicalrep_write_typ()

2024-07-14 Thread Amit Kapila
On Thu, Jul 11, 2024 at 4:35 PM cca5507 wrote: > > Thank you for review! > > The commitfest link for tracking: > https://commitfest.postgresql.org/49/5121/ > I've pushed and closed the CF entry. -- With Regards, Amit Kapila.

Re: Fix a comment error in logicalrep_write_typ()

2024-07-11 Thread cca5507
Thank you for review! The commitfest link for tracking: https://commitfest.postgresql.org/49/5121/ -- Regards, ChangAo Chen

Re: Fix a comment error in logicalrep_write_typ()

2024-07-11 Thread Amit Kapila
On Thu, Jul 11, 2024 at 12:46 PM cca5507 wrote: > > - /* use Oid as relation identifier */ > + /* use Oid as type identifier */ > pq_sendint32(out, typoid); > > I think it must be "type identifier" rather than "relation identifier". > LGTM. -- With Regards, Amit Kapila.

Fix a comment error in logicalrep_write_typ()

2024-07-11 Thread cca5507
Hi, -       /* use Oid as relation identifier */ +       /* use Oid as type identifier */         pq_sendint32(out, typoid); I think it must be "type identifier" rather than "relation identifier". -- Regards, ChangAo Chen 0001-Fix-a-comment-error-in-logicalrep_write_typ.patch Description: B