Re: Fallout from PQhost() semantics changes

2018-08-03 Thread Tom Lane
Haribabu Kommi writes: > On Fri, Aug 3, 2018 at 2:24 AM Tom Lane wrote: >> What I think we should do about it is change those internal calls to >> fetch connhost[].host directly instead of going through PQhost(), as >> in the attached libpq-internal-PQhost-usage-1.patch. This will restore >> the

Re: Fallout from PQhost() semantics changes

2018-08-03 Thread Haribabu Kommi
On Fri, Aug 3, 2018 at 2:24 AM Tom Lane wrote: > Traditionally (prior to v10), PQhost() returned the "host" connection > parameter if that was nonempty, otherwise the default host name > (DEFAULT_PGSOCKET_DIR or "localhost" depending on platform). > > That got whacked around to a state of brokenn

Fallout from PQhost() semantics changes

2018-08-02 Thread Tom Lane
Traditionally (prior to v10), PQhost() returned the "host" connection parameter if that was nonempty, otherwise the default host name (DEFAULT_PGSOCKET_DIR or "localhost" depending on platform). That got whacked around to a state of brokenness in v10 (which I'll return to in a bit), and then commi