Re: Failures with installcheck and low work_mem value in 13~

2020-06-25 Thread Michael Paquier
On Thu, Jun 25, 2020 at 12:15:54PM -0700, Peter Geoghegan wrote: > The RMT met today. We determined that it wasn't worth adjusting this > test to pass with non-standard work_mem values. Okay, thanks for the feedback. We'll see how it works out. -- Michael signature.asc Description: PGP signatur

Re: Failures with installcheck and low work_mem value in 13~

2020-06-25 Thread Peter Geoghegan
On Fri, Jun 19, 2020 at 7:48 PM Michael Paquier wrote: > We cared about such plan stability that in the past FWIW, see for > example c588df9 as work_mem is a setting that people like to change. > Why should this be different? work_mem is a popular configuration > setting. The RMT met today. We d

Re: Failures with installcheck and low work_mem value in 13~

2020-06-19 Thread Michael Paquier
On Fri, Jun 19, 2020 at 10:28:56AM -0700, Peter Geoghegan wrote: > On Fri, Jun 19, 2020 at 10:27 AM Tom Lane wrote: >> I'm a bit skeptical about changing anything here. There are quite >> a large number of GUCs that can affect the regression results, and >> it wouldn't be sane to try to force the

Re: Failures with installcheck and low work_mem value in 13~

2020-06-19 Thread Peter Geoghegan
On Fri, Jun 19, 2020 at 10:27 AM Tom Lane wrote: > Tomas Vondra writes: > > I don't think the tests can be made not to depend on work_mem, because > > it costing of sort / incremental sort depends on the value. I agree > > setting the work_mem at the beginning of the test script is the right > >

Re: Failures with installcheck and low work_mem value in 13~

2020-06-19 Thread Tom Lane
Tomas Vondra writes: > I don't think the tests can be made not to depend on work_mem, because > it costing of sort / incremental sort depends on the value. I agree > setting the work_mem at the beginning of the test script is the right > solution. I'm a bit skeptical about changing anything here.

Re: Failures with installcheck and low work_mem value in 13~

2020-06-19 Thread Tomas Vondra
On Mon, Jun 15, 2020 at 10:29:41PM +0900, Michael Paquier wrote: Hi all, Attempting to run installcheck with 13~ and a value of work_mem lower than the default causes two failures, both related to incremental sorts (here work_mem = 1MB): 1) Test incremental_sort: @@ -4,12 +4,13 @@ select * from

Re: Failures with installcheck and low work_mem value in 13~

2020-06-19 Thread Tomas Vondra
On Tue, Jun 16, 2020 at 02:39:47PM +0900, Michael Paquier wrote: On Mon, Jun 15, 2020 at 10:29:41PM +0900, Michael Paquier wrote: Attempting to run installcheck with 13~ and a value of work_mem lower than the default causes two failures, both related to incremental sorts (here work_mem = 1MB): 1

Re: Failures with installcheck and low work_mem value in 13~

2020-06-15 Thread Michael Paquier
On Mon, Jun 15, 2020 at 10:29:41PM +0900, Michael Paquier wrote: > Attempting to run installcheck with 13~ and a value of work_mem lower > than the default causes two failures, both related to incremental > sorts (here work_mem = 1MB): > 1) Test incremental_sort: > @@ -4,12 +4,13 @@ > select * fro

Failures with installcheck and low work_mem value in 13~

2020-06-15 Thread Michael Paquier
Hi all, Attempting to run installcheck with 13~ and a value of work_mem lower than the default causes two failures, both related to incremental sorts (here work_mem = 1MB): 1) Test incremental_sort: @@ -4,12 +4,13 @@ select * from (select * from tenk1 order by four) t order by four, ten;