On 2021-Jun-14, Masahiko Sawada wrote:
> The condition should be the opposite; we should raise the error when
> 'nowait' is true. I think this is the cause of the test failure. Even
> if DROP SUBSCRIPTION tries to drop the slot with the WAIT option, we
> don't wait but raise the error.
Hi, thanks
On 2021-Jun-14, Amit Kapila wrote:
> On Mon, Jun 14, 2021 at 10:41 AM Masahiko Sawada
> wrote:
> > The condition should be the opposite; we should raise the error when
> > 'nowait' is true. I think this is the cause of the test failure. Even
> > if DROP SUBSCRIPTION tries to drop the slot with
On Mon, Jun 14, 2021 at 10:41 AM Masahiko Sawada wrote:
>
> >
> > I think it is showing a race condition issue in the code. In
> > DropSubscription, we first stop the worker that is receiving the WAL,
> > and then in a separate connection with the publisher, it tries to drop
> > the slot which lea
On Sat, Jun 12, 2021 at 9:57 PM Amit Kapila wrote:
>
> On Sat, Jun 12, 2021 at 1:13 PM Michael Paquier wrote:
> >
> > wrasse has just failed with what looks like a timing error with a
> > replication slot drop:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2021-06-12%2006%
Amit Kapila writes:
> On Sat, Jun 12, 2021 at 1:13 PM Michael Paquier wrote:
>> wrasse has just failed with what looks like a timing error with a
>> replication slot drop:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2021-06-12%2006%3A16%3A30
> If we want to fix this, we
On Sat, Jun 12, 2021 at 1:13 PM Michael Paquier wrote:
>
> wrasse has just failed with what looks like a timing error with a
> replication slot drop:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2021-06-12%2006%3A16%3A30
>
> Here is the error:
> error running SQL: 'psql::1:
Hi all,
wrasse has just failed with what looks like a timing error with a
replication slot drop:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2021-06-12%2006%3A16%3A30
Here is the error:
error running SQL: 'psql::1: ERROR: could not drop replication
slot "tap_sub" on publish
