Hi
On Friday, March 25, 2022 2:36 PM Masahiko Sawada wrote:
> On Thu, Mar 24, 2022 at 12:30 PM Amit Kapila
> wrote:
> >
> > On Thu, Mar 3, 2022 at 8:58 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> >
> > This patch introduces two new subscription statistics columns
> > (apply_commit_count a
On Thu, Mar 24, 2022 at 12:30 PM Amit Kapila wrote:
>
> On Thu, Mar 3, 2022 at 8:58 AM osumi.takami...@fujitsu.com
> wrote:
> >
>
> This patch introduces two new subscription statistics columns
> (apply_commit_count and apply_rollback_count) to the
> pg_stat_subscription_stats view for counting c
On Thu, Mar 3, 2022 at 8:58 AM osumi.takami...@fujitsu.com
wrote:
>
This patch introduces two new subscription statistics columns
(apply_commit_count and apply_rollback_count) to the
pg_stat_subscription_stats view for counting cumulative transactions
commits/rollbacks for a particular subscripti
On Wednesday, March 2, 2022 5:29 PM Shi, Yu/侍 雨 wrote:
> A comments on the v26 patch.
Thank you for checking the patch !
>
> The following document about pg_stat_subscription_stats view only says that
> "showing statistics about errors", should we add something about transactions
> here?
>
>
On Wednesday, March 2, 2022 2:18 PM Masahiko Sawada
wrote:
> On Wed, Mar 2, 2022 at 10:21 AM osumi.takami...@fujitsu.com
> wrote:
> > Also, I quickly checked other similar views(pg_stat_slru,
> > pg_stat_wal_receiver) commit logs, especially when they introduce columns.
> > But, I couldn't find
Hi,
A comments on the v26 patch.
The following document about pg_stat_subscription_stats view only says that
"showing statistics about errors", should we add something about transactions
here?
pg_stat_subscription_statspg_stat_subscription_stats
One row per subscription, show
On Wed, Mar 2, 2022 at 10:21 AM osumi.takami...@fujitsu.com
wrote:
>
>
> Also, I quickly checked other similar views(pg_stat_slru,
> pg_stat_wal_receiver)
> commit logs, especially when they introduce columns.
> But, I couldn't find column name validations.
> So, I feel this is aligned.
>
I've l
On Tuesday, March 1, 2022 4:12 PM Peter Smith wrote:
> Please see below my review comments for v25.
>
> ==
>
> 1. Commit message
>
> Introduce cumulative columns of transactions of logical replication subscriber
> to the pg_stat_subscription_stats view.
>
> "cumulative columns of transacti
Please see below my review comments for v25.
==
1. Commit message
Introduce cumulative columns of transactions of
logical replication subscriber to the pg_stat_subscription_stats view.
"cumulative columns of transactions" sounds a bit strange to me.
SUGGESTED
Introduce 2 new subscription s
On Friday, February 25, 2022 7:58 AM osumi.takami...@fujitsu.com
wrote:
> Kindly have a look at v24.
Hi.
The recent commit(7a85073) has redesigned the view pg_stat_subscription_workers
and now we have pg_stat_subscription_stats. Therefore, I rebased my patch
so that my statistics patch can be ap
On Wednesday, February 23, 2022 3:30 PM Amit Kapila
> On Tue, Feb 22, 2022 at 6:45 AM tanghy.f...@fujitsu.com
> wrote:
> >
> > I found a problem when using it. When a replication workers exits, the
> > transaction stats should be sent to stats collector if they were not
> > sent before because it
On Thursday, February 24, 2022 11:07 AM Masahiko Sawada
wrote:
> I have some comments on v23 patch:
>
> @@ -66,6 +66,12 @@ typedef struct LogicalRepWorker
> TimestampTz last_recv_time;
> XLogRecPtr reply_lsn;
> TimestampTz reply_time;
> +
> + /*
> +* Transaction statistics of
On Mon, Feb 21, 2022 at 12:45 PM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
> wrote:
> > On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
> > wrote:
> > > On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> > > wrote
On Tue, Feb 22, 2022 at 6:45 AM tanghy.f...@fujitsu.com
wrote:
>
> I found a problem when using it. When a replication workers exits, the
> transaction stats should be sent to stats collector if they were not sent
> before
> because it didn't reach PGSTAT_STAT_INTERVAL. But I saw that the stats w
On Tuesday, February 22, 2022 10:15 AM Tang, Haiying/唐 海英
wrote:
> On Mon, Feb 21, 2022 11:46 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
> > wrote:
> > > On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
> > > wrote
On Mon, Feb 21, 2022 11:46 AM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
> wrote:
> > On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
> > wrote:
> > > On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> > > wrote:
On Monday, February 21, 2022 6:06 PM Monday, February 21, 2022 6:06 PM wrote:
> On Mon, Feb 21, 2022 11:46 AM Osumi, Takamichi/大墨 昂道
> wrote:
> >I've addressed this point in a new v23 patch, since there was no opinion on
> this so far.
> >Kindly have a look at the attached one.
> Thanks for updati
On Mon, Feb 21, 2022 11:46 AM Osumi, Takamichi/大墨 昂道
wrote:
>I've addressed this point in a new v23 patch, since there was no opinion on
>this so far.
>Kindly have a look at the attached one.
Thanks for updating the patch. Here is a comment:
In function apply_handle_stream_abort:
@@ -1217,6 +12
On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
wrote:
> On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
> wrote:
> > On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> > wrote:
> > 4) I noticed that the abort_count doesn't include aborted streaming
> > trans
On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
wrote:
> On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > The attached v21 has a couple of other minor updates like a
> > modification of error message text.
> >
> >
>
> Thanks for updating the patch. Here are some
On Friday, February 18, 2022 8:11 PM Amit Kapila
wrote:
> On Fri, Feb 18, 2022 at 2:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, February 17, 2022 6:45 PM Amit Kapila
> wrote:
> > > On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila
> > >
> > > wrote:
> > > > Can't we use pgstat_re
On Fri, Feb 18, 2022 at 2:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, February 17, 2022 6:45 PM Amit Kapila
> wrote:
> > On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila
> > wrote:
> > > Can't we use pgstat_report_stat() here? Basically, you can update xact
> > > completetion counters
On Thursday, February 17, 2022 6:45 PM Amit Kapila
wrote:
> On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila
> wrote:
> >
> > On Tue, Jan 4, 2022 at 5:22 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Friday, December 31, 2021 10:12 AM Tang, Haiying/唐 海英
> wrote:
> > > > 4)
> > > > +void
On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
wrote:
>
> The attached v21 has a couple of other minor updates
> like a modification of error message text.
>
>
Thanks for updating the patch. Here are some comments.
1) I saw the following description about pg_stat_subscription_worke
On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila wrote:
>
> On Tue, Jan 4, 2022 at 5:22 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Friday, December 31, 2021 10:12 AM Tang, Haiying/唐 海英
> > wrote:
> > > 4)
> > > +void
> > > +pgstat_send_subworker_xact_stats(LogicalRepWorker *repWorker, bool
>
On Tue, Jan 4, 2022 at 5:22 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, December 31, 2021 10:12 AM Tang, Haiying/唐 海英
> wrote:
> > 4)
> > +void
> > +pgstat_send_subworker_xact_stats(LogicalRepWorker *repWorker, bool
> > +force) {
> > + static TimestampTz last_report = 0;
> > + P
On Wed, Jan 12, 2022 at 6:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, December 23, 2021 6:37 PM Wang, Wei/王 威
> wrote:
> > On Wednesday, December 22, 2021 10:30 PM osumi.takami...@fujitsu.com
> > wrote:
> > > On Wednesday, December 22, 2021 8:38 PM I wrote:
> > > > Do we expect th
On Thursday, December 23, 2021 6:37 PM Wang, Wei/王 威
wrote:
> On Wednesday, December 22, 2021 10:30 PM osumi.takami...@fujitsu.com
> wrote:
> > On Wednesday, December 22, 2021 8:38 PM I wrote:
> > > Do we expect these commit counts which come from empty transactions ?
> > This is another issue d
On Friday, December 31, 2021 10:12 AM Tang, Haiying/唐 海英
wrote:
> On Wednesday, December 22, 2021 6:14 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Attached the new patch v19.
> >
>
> Thanks for your patch. I think it's better if you could add this patch to the
> commitfest.
> Here are some
On Monday, January 3, 2022 2:46 PM Hou, Zhijie/侯 志杰
wrote:
> On Wednesday, December 22, 2021 6:14 PM Osumi, Takamichi
> wrote:
> > Attached the new patch v19.
> Hi,
>
> Thanks for updating the patch.
>
> --- a/src/include/pgstat.h
> +++ b/src/include/pgstat.h
> @@ -15,6 +15,7 @@
> #include "p
On Wednesday, December 22, 2021 6:14 PM Osumi, Takamichi
wrote:
> Attached the new patch v19.
Hi,
Thanks for updating the patch.
--- a/src/include/pgstat.h
+++ b/src/include/pgstat.h
@@ -15,6 +15,7 @@
#include "portability/instr_time.h"
#include "postmaster/pgarch.h" /* for MAX_XFN_CHARS */
On Wednesday, December 22, 2021 6:14 PM osumi.takami...@fujitsu.com
wrote:
>
> Attached the new patch v19.
>
Thanks for your patch. I think it's better if you could add this patch to the
commitfest.
Here are some comments:
1)
+ commit_count bigint
+
+
+ Number of tran
On Wednesday, December 22, 2021 10:30 PM
osumi.takami...@fujitsu.com wrote:
> On Wednesday, December 22, 2021 8:38 PM I wrote:
> > Do we expect these commit counts which come from empty transactions ?
> This is another issue discussed in [1]
> where the patch in the thread is a work in progress, I
On Wednesday, December 22, 2021 9:38 PM Wang, Wei/王 威
wrote:
> I have a question on the v19-0002 patch:
>
> When I tested for this patch, I found pg_stat_subscription_workers has some
> unexpected data.
> For example:
> [Publisher]
> create table replica_test1(a int, b text); create publication
On Mon, Dec 22, 2021 at 6:14 PM osumi.takami...@fujitsu.com
wrote:
>
> Attached the new patch v19.
>
I have a question on the v19-0002 patch:
When I tested for this patch, I found pg_stat_subscription_workers has some
unexpected data.
For example:
[Publisher]
create table replica_test1(a int,
On Tuesday, December 21, 2021 6:00 PM Greg Nancarrow
wrote:
> Some review comments on the v18 patches:
Thank you for your review !
> v18-0002
>
> doc/src/sgml/monitoring.sgml
> (1) tablesync worker stats?
>
> Shouldn't the comment below only mention the apply worker? (since we're no
> longer r
On Mon, Dec 20, 2021 at 8:40 PM osumi.takami...@fujitsu.com
wrote:
>
> Updated the patch to address your concern.
>
Some review comments on the v18 patches:
v18-0002
doc/src/sgml/monitoring.sgml
(1) tablesync worker stats?
Shouldn't the comment below only mention the apply worker? (since
we're
Friday, December 17, 2021 2:03 PM Kyotaro Horiguchi
wrote:
> It sends stats packets at every commit-like operation on apply workers. The
> current pgstat is so smart that it refrain from sending stats packets at too
> high
> frequency. We already suffer frequent stats packets so apply workers
At Thu, 16 Dec 2021 11:36:46 +, "osumi.takami...@fujitsu.com"
wrote in
> On Thursday, December 16, 2021 4:00 PM I wrote:
> > Thank you, everyone for confirming the direction.
> > I'll follow the consensus of the community and fix the patch, including
> > other
> > comments.
> > I'll treat o
On Thursday, December 16, 2021 8:37 PM I wrote:
> Hi, created a new version v17 according to the recent discussion with changes
> to address other review comments.
FYI, in v17 I've removed one part of commit message
about spool file statistics on the subscriber.
My intention is just to make the pat
On Tuesday, December 14, 2021 12:45 AM vignesh C wrote:
> Thanks for the updated patch, few comments:
> 1) Can we change this:
> /*
> +* Report the success of table sync as one commit to consolidate all
> +* transaction stats into one record.
> +*/
> + pgstat_
On Monday, December 13, 2021 6:19 PM Amit Kapila
wrote:
> On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> wrote:
> >
>
> Few questions and comments:
>
> 1.
> The pg_stat_subscription_workers view will
> contain
> one row per subscription worker on which
On Thursday, December 16, 2021 4:00 PM I wrote:
> Thank you, everyone for confirming the direction.
> I'll follow the consensus of the community and fix the patch, including other
> comments.
> I'll treat only the stats for apply workers.
Hi, created a new version v17 according to the recent discus
On Tue, Dec 14, 2021 at 1:28 PM Amit Kapila wrote:
>
> If we fear a large number of entries for such workers then won't it be
> better to show the value of these stats only for apply workers. I
> think normally the table sync workers perform only copy operation or
> maybe a fixed number of xacts,
On Wednesday, December 15, 2021 9:52 PM vignesh C wrote:
> On Tue, Dec 14, 2021 at 7:58 AM Amit Kapila
> wrote:
> >
> > On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, December 13, 2021 6:19 PM Amit Kapila
> wrote:
> > > > On Tue, Dec 7, 2021 at 3:1
On Tue, Dec 14, 2021 at 7:58 AM Amit Kapila wrote:
>
> On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, December 13, 2021 6:19 PM Amit Kapila
> > wrote:
> > > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > >
> > > Few question
On Tue, Dec 14, 2021 at 11:28 AM Amit Kapila wrote:
>
> On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, December 13, 2021 6:19 PM Amit Kapila
> > wrote:
> > > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > >
> > > Few questio
On Tues, Dec 14, 2021 10:28 AM Amit Kapila wrote:
> On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, December 13, 2021 6:19 PM Amit Kapila
> wrote:
> > > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > >
> > > Few questions and
On Mon, Dec 13, 2021 at 5:48 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 13, 2021 6:19 PM Amit Kapila
> wrote:
> > On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> > wrote:
> >
> > Few questions and comments:
> Thank you for your comments !
>
> > ==
On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, December 6, 2021 11:27 PM vignesh C wrote:
> > Thanks for the updated patch, few comments:
> Thank you for your review !
>
> > 1) We can keep the documentation similar to mention the count includes both
> > table syn
On Monday, December 13, 2021 6:19 PM Amit Kapila
wrote:
> On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
> wrote:
>
> Few questions and comments:
Thank you for your comments !
>
> 1.
> The pg_stat_subscription_workers view will
> contain
> one row per s
On Tue, Dec 7, 2021 at 3:12 PM osumi.takami...@fujitsu.com
wrote:
>
Few questions and comments:
1.
The pg_stat_subscription_workers view will contain
one row per subscription worker on which errors have occurred, for workers
applying logical replication changes an
On Monday, December 6, 2021 11:27 PM vignesh C wrote:
> Thanks for the updated patch, few comments:
Thank you for your review !
> 1) We can keep the documentation similar to mention the count includes both
> table sync worker / main apply worker in case of commit_count/error_count
> and abort_cou
On Sat, Dec 4, 2021 at 6:32 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, December 3, 2021 3:12 PM vignesh C wrote:
> > Thanks for the updated patch.
> > Currently we are storing the commit count, error_count and abort_count for
> > each table of the table sync operation. If we have thousa
On Friday, December 3, 2021 3:12 PM vignesh C wrote:
> Thanks for the updated patch.
> Currently we are storing the commit count, error_count and abort_count for
> each table of the table sync operation. If we have thousands of tables, we
> will
> be storing the information for each of the tables
On Wed, Dec 1, 2021 at 3:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Friday, November 19, 2021 11:11 PM Masahiko Sawada
> wrote:
> > Besides that, I’m not sure how useful commit_bytes, abort_bytes, and
> > error_bytes are. I originally thought these statistics track the size of
> > received
On Friday, November 19, 2021 11:11 PM Masahiko Sawada
wrote:
> Besides that, I’m not sure how useful commit_bytes, abort_bytes, and
> error_bytes are. I originally thought these statistics track the size of
> received
> data, i.g., how much data is transferred from the publisher and processed on
On Tue, Nov 23, 2021 at 3:21 PM Greg Nancarrow wrote:
>
> On Sat, Nov 20, 2021 at 1:11 AM Masahiko Sawada wrote:
> >
> > I'm concerned that these new names will introduce confusion; if we
> > have last_error_relid, last_error_command, last_error_message,
> > last_error_time, and last_error_xid, I
On Sat, Nov 20, 2021 at 3:25 PM Amit Kapila wrote:
>
> On Fri, Nov 19, 2021 at 7:41 PM Masahiko Sawada wrote:
> >
> > On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila
> > wrote:
> > >
> > > On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
> > > > On Wednesday, Novem
On Sat, Nov 20, 2021 at 1:11 AM Masahiko Sawada wrote:
>
> I'm concerned that these new names will introduce confusion; if we
> have last_error_relid, last_error_command, last_error_message,
> last_error_time, and last_error_xid, I think users might think that
> first_error_time is the timestamp a
On Fri, Nov 19, 2021 at 7:41 PM Masahiko Sawada wrote:
>
> On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila wrote:
> >
> > On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Wednesday, November 17, 2021 10:00 PM Amit Kapila
> > > wrote:
> > > >
> > > > Can you pl
On Fri, Nov 19, 2021 at 7:41 PM Masahiko Sawada wrote:
>
> On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila wrote:
> >
> > On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Wednesday, November 17, 2021 10:00 PM Amit Kapila
> > > wrote:
> > > >
> > > > Can you pl
On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila wrote:
>
> On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Wednesday, November 17, 2021 10:00 PM Amit Kapila
> > wrote:
> > >
> > > Can you please tell us why you think the names in your proposed patch are
> > > better
On Thursday, November 18, 2021 12:26 PM Amit Kapila
wrote:
> BTW, I think the way you are computing error_count in
> pgstat_recv_subworker_error() doesn't seem correct to me because it will
> accumulate the counter/bytes for the same error again and again.
> You might want to update these counter
On Thursday, November 18, 2021 8:35 PM vignesh C wrote:
> On Tue, Nov 16, 2021 at 6:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, November 15, 2021 9:14 PM I wrote:
> > > I've conducted some update for this.
> > > (The rebased part is only C code and checked by pgindent)
> > I'll
On Tue, Nov 16, 2021 at 6:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, November 15, 2021 9:14 PM I wrote:
> > I've conducted some update for this.
> > (The rebased part is only C code and checked by pgindent)
> I'll update my patches since a new skip xid patch
> has been shared in [1].
On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, November 17, 2021 10:00 PM Amit Kapila
> wrote:
> >
> > Can you please tell us why you think the names in your proposed patch are
> > better than the existing names proposed in Sawada-San's patch? Is it because
On Wednesday, November 17, 2021 10:00 PM Amit Kapila
wrote:
> On Wed, Nov 17, 2021 at 9:44 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada
> wrote:
> > > On Tue, Nov 16, 2021 at 9:34 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
>
On Wed, Nov 17, 2021 at 9:44 AM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada
> wrote:
> > On Tue, Nov 16, 2021 at 9:34 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, November 15, 2021 9:14 PM I wrote:
> > > > I've conducted so
On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada
wrote:
> On Tue, Nov 16, 2021 at 9:34 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, November 15, 2021 9:14 PM I wrote:
> > > I've conducted some update for this.
> > > (The rebased part is only C code and checked by pgindent)
On Tue, Nov 16, 2021 at 9:34 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, November 15, 2021 9:14 PM I wrote:
> > I've conducted some update for this.
> > (The rebased part is only C code and checked by pgindent)
> I'll update my patches since a new skip xid patch
> has been shared in [1].
On Monday, November 15, 2021 9:14 PM I wrote:
> I've conducted some update for this.
> (The rebased part is only C code and checked by pgindent)
I'll update my patches since a new skip xid patch
has been shared in [1].
This version includes some minor renames of functions
that are related to trans
On Monday, November 15, 2021 6:28 PM I wrote:
> On Thursday, November 11, 2021 9:47 PM vignesh C
> wrote:
> > Few more comments:
...
> Fixed. Also, its name was too long
> when aligned with other PgStat_StatDBEntry memebers.
> Thus I renamed it as subworkers_preparedsizes.
>
> This depends on v21
On Wednesday, November 10, 2021 6:13 PM I wrote:
> On Wednesday, November 10, 2021 3:43 PM Dilip Kumar
> wrote:
> > On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
> > wrote:
> > > On Tuesday, November 9, 2021 12:08 PM Greg Nancarrow
> > wrote:
> > > > On Fri, Nov 5, 2021 at 7:11 PM o
On Wednesday, November 10, 2021 7:13 PM vignesh C wrote:
> On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
> wrote:
> > Yes. I've rebased and updated the patch, paying attention to this point.
> > Attached the updated version.
>
> Thanks for the updated patch, few comments:
> 1) you c
On Thursday, November 11, 2021 9:47 PM vignesh C wrote:
> Few more comments:
> 1) Here the tuple length is not considered in the calculation, else it will
> always
> show the fixed size for any size tuple. Ex varchar insert with 1 byte or
> varchar
> insert with 100's of bytes. So I feel we shou
On Wed, Nov 10, 2021 at 3:43 PM vignesh C wrote:
>
> On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
> wrote:
> > Yes. I've rebased and updated the patch, paying attention to this point.
> > Attached the updated version.
>
> Thanks for the updated patch, few comments:
> 6) Few places y
On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
wrote:
> Yes. I've rebased and updated the patch, paying attention to this point.
> Attached the updated version.
Thanks for the updated patch, few comments:
1) you could rename PgStat_StatSubWorkerPreparedXact to
PgStat_SW_PreparedXactKe
On Wednesday, November 10, 2021 3:43 PM Dilip Kumar
wrote:
> On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
> wrote:
> > On Tuesday, November 9, 2021 12:08 PM Greg Nancarrow
> wrote:
> > > On Fri, Nov 5, 2021 at 7:11 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
> > >
> > > I
On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com
wrote:
>
> On Tuesday, November 9, 2021 12:08 PM Greg Nancarrow
> wrote:
> > On Fri, Nov 5, 2021 at 7:11 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> >
> > I did a quick scan through the latest v8 patch and noticed the following
>
On Tuesday, November 9, 2021 8:35 PM I wrote:
> Yes. I've rebased and updated the patch, paying attention to this point.
> Attached the updated version.
Forgot to note one thing.
This is based on the skip xid v20 shared in [1]
[1] -
https://www.postgresql.org/message-id/CAD21AoAT42mhcqeB1jPfRL1%2
On Monday, November 8, 2021 3:12 PM vignesh C wrote:
> On Fri, Nov 5, 2021 at 1:42 PM osumi.takami...@fujitsu.com
> wrote:
> > Lastly, I removed one unnecessary test that checked publisher's stats
> > in the TAP tests.
> > Also I introduced ApplyTxnExtraData structure to remove void* argument
> >
On Tuesday, November 9, 2021 12:08 PM Greg Nancarrow
wrote:
> On Fri, Nov 5, 2021 at 7:11 PM osumi.takami...@fujitsu.com
> wrote:
> >
>
> I did a quick scan through the latest v8 patch and noticed the following
> things:
I appreciate your review !
> src/backend/postmaster/pgstat.c
>
> (1) pg
On Fri, Nov 5, 2021 at 7:11 PM osumi.takami...@fujitsu.com
wrote:
>
I did a quick scan through the latest v8 patch and noticed the following things:
src/backend/postmaster/pgstat.c
(1) pgstat_recv_subworker_twophase_xact()
The copying from msg->m_gid to key.gid does not seem to be correct.
strl
On Fri, Nov 5, 2021 at 7:11 PM osumi.takami...@fujitsu.com
wrote:
>
> I'm not sure about the last part.
> > additionally increase the available subscriber memory,
> Which GUC parameter did you mean by this ?
> Could we point out and enalrge the memory size only for
> subscriber's apply processing
On Fri, Nov 5, 2021 at 1:42 PM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, November 4, 2021 9:54 AM Greg Nancarrow
> wrote:
> > On Tue, Nov 2, 2021 at 12:18 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Thursday, October 28, 2021 11:19 PM I wrote:
> > > > I've created a new
On Thursday, November 4, 2021 9:54 AM Greg Nancarrow
wrote:
> On Tue, Nov 2, 2021 at 12:18 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, October 28, 2021 11:19 PM I wrote:
> > > I've created a new patch that extends pg_stat_subscription_workers
> > > to include other transaction
On Tue, Nov 2, 2021 at 12:18 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, October 28, 2021 11:19 PM I wrote:
> > I've created a new patch that extends pg_stat_subscription_workers to
> > include
> > other transaction statistics.
> >
> > Note that this patch depends on v18 patch-set in [
On Monday, November 1, 2021 10:18 PM I wrote:
> On Thursday, October 28, 2021 11:19 PM I wrote:
> > I've created a new patch that extends pg_stat_subscription_workers to
> > include other transaction statistics.
> >
> > Note that this patch depends on v18 patch-set in [1]...
> Rebased based on the
On Thursday, October 28, 2021 11:19 PM I wrote:
> I've created a new patch that extends pg_stat_subscription_workers to include
> other transaction statistics.
>
> Note that this patch depends on v18 patch-set in [1]...
Rebased based on the v19 in [1].
Also, fixed documentation a little and made t
On Thursday, October 21, 2021 10:19 AM Masahiko Sawada
wrote:
> On Mon, Oct 18, 2021 at 7:03 PM Amit Kapila
> wrote:
> >
> > On Thu, Oct 14, 2021 at 9:23 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> > >
> > > >
> > > > These all views
On Thu, Oct 21, 2021 at 6:49 AM Masahiko Sawada wrote:
>
> On Mon, Oct 18, 2021 at 7:03 PM Amit Kapila wrote:
> >
> > On Thu, Oct 14, 2021 at 9:23 AM houzj.f...@fujitsu.com
> > wrote:
> > >
> > > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> > >
> > > >
> > > > These all views are rel
On Mon, Oct 18, 2021 at 7:03 PM Amit Kapila wrote:
>
> On Thu, Oct 14, 2021 at 9:23 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> >
> > >
> > > These all views are related to untransmitted to the collector but what
> > > we really need is a vi
On Monday, October 18, 2021 11:52 AM Hou, Zhijie/侯 志杰
wrote:
> On Thursday, October 14, 2021 2:13 PM Osumi, Takamichi wrote:
> > On Thursday, October 14, 2021 12:54 PM Hou,
> Zhijie wrote:
> > > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> > > > On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhij
On Monday, October 18, 2021 6:04 PM Amit Kapila wrote:
> On Thu, Oct 14, 2021 at 9:23 AM houzj.f...@fujitsu.com
> wrote:
> >
> > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> >
> > >
> > > These all views are related to untransmitted to the collector but
> > > what we really need is a v
On Thu, Oct 14, 2021 at 9:23 AM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, September 30, 2021 12:15 PM Amit Kapila
> >
> > These all views are related to untransmitted to the collector but what
> > we really need is a view similar to pg_stat_archiver or
> > pg_stat_bgwriter which gives inform
On Thursday, October 14, 2021 2:13 PM Osumi, Takamichi wrote:
> On Thursday, October 14, 2021 12:54 PM Hou, Zhijie
> wrote:
> > On Thursday, September 30, 2021 12:15 PM Amit Kapila
> > > On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhijie/侯 志杰wrote:
> > > >
> > > > On Tues, Sep 28, 2021 6:05 PM Amit Kapil
On Thursday, October 14, 2021 12:54 PM Hou, Zhijie/侯 志杰
wrote:
> On Thursday, September 30, 2021 12:15 PM Amit Kapila
>
> > On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhijie/侯 志杰
> wrote:
> > >
> > > On Tues, Sep 28, 2021 6:05 PM Amit Kapila
> wrote:
> > > >
> > > > Can't we keep the current and new
On Thursday, September 30, 2021 12:15 PM Amit Kapila
> On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhijie/侯 志杰
> wrote:
> >
> > On Tues, Sep 28, 2021 6:05 PM Amit Kapila wrote:
> > >
> > > Can't we keep the current and new stats both in-memory and persist on
> > > disk? So, the persistent stats data w
On Thursday, September 30, 2021 8:13 PM Amit Kapila
wrote:
> On Thu, Sep 30, 2021 at 1:02 PM Osumi, Takamichi/大墨 昂道
> wrote:
> >
> > On Thursday, September 30, 2021 1:15 PM Amit Kapila
> wrote:
> > > On Thu, Sep 30, 2021 at 8:22 AM Hou, Zhijie/侯 志杰
> > > wrote:
> > > >
> > > > On Tues, Sep 28,
1 - 100 of 140 matches
Mail list logo
