Re: Extra quote_all_identifiers in _dumpOptions

2019-07-09 Thread Arthur Zakirov
On 09.07.2019 02:32, Bruce Momjian wrote: diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h index db30b54a92..8c0cedcd98 100644 --- a/src/bin/pg_dump/pg_backup.h +++ b/src/bin/pg_dump/pg_backup.h @@ -153,7 +153,6 @@ typedef struct _dumpOptions int

Re: Extra quote_all_identifiers in _dumpOptions

2019-07-09 Thread Michael Paquier
On Mon, Jul 08, 2019 at 07:32:07PM -0400, Bruce Momjian wrote: > Wow, good catch. I thought C compilers would have reported this issue, > but obviously not. Patch applied to head. Thanks. Yes, I don't recall that gcc nor clang have a magic recipy for that. We have a couple of other orphaned one

Re: Extra quote_all_identifiers in _dumpOptions

2019-07-08 Thread Bruce Momjian
On Thu, Jun 27, 2019 at 12:12:15PM +0300, Arthur Zakirov wrote: > Hello hackers, > > While working on pg_dump I noticed the extra quote_all_identifiers in > _dumpOptions struct. I attached the patch. > > It came from refactoring by 0eea8047bf. There is also a d

Extra quote_all_identifiers in _dumpOptions

2019-06-27 Thread Arthur Zakirov
Hello hackers, While working on pg_dump I noticed the extra quote_all_identifiers in _dumpOptions struct. I attached the patch. It came from refactoring by 0eea8047bf. There is also a discussion: https://www.postgresql.org/message-id/CACw0%2B13ZUcXbj9GKJNGZTkym1SXhwRu28nxHoJMoX5Qwmbg_%2Bw