On Fri, 7 Mar 2025 at 17:22, Andreas Karlsson wrote:
>
> Hi,
>
> Here is a rebased version of it to make the CI happy. I plan to work
> more on this next week but am happy with any feedback on what is already
> there.
I noticed that Kirill's comments from [1] are not yet addressed, I
have changed
On Fri, 7 Mar 2025 at 16:52, Andreas Karlsson wrote:
>
> Hi,
Hi!
> Here is a rebased version of it to make the CI happy.
Looks like CI is still unhappy with this change[0]
0001:
>+
>+SMgrId
>+smgr_register(const f_smgr *smgr, Size smgrrelation_size)
...
> + Assert(smgr->smgr_open != NULL);
>
On 9/21/24 8:24 PM, Nitin Jadhav wrote:
I reviewed the discussion and took a look at the patch sets. It seems
like many things are combined here. Based on the subject, I initially
thought it aimed to provide the infrastructure to easily extend
storage managers. This would allow anyone to create t
Thank you for your detailed review and insights. I share your view that a
registration-based approach for custom storage managers (smgr) is more
versatile. This method allows for the implementation of custom table access
methods, facilitating the use of various storage services (such as file
servic
Hi,
I reviewed the discussion and took a look at the patch sets. It seems
like many things are combined here. Based on the subject, I initially
thought it aimed to provide the infrastructure to easily extend
storage managers. This would allow anyone to create their own storage
managers using this
Hi,
> Thought I would show off what is possible with this patchset.
>
> [...]
Just wanted to let you know that cfbot doesn't seem to be entirely
happy with the patch [1]. Please consider submitting an updated
version.
Best regards,
Aleksander Alekseev (wearing co-CFM hat)
[1]: http://cfbot.cput
Thought I would show off what is possible with this patchset.
Heikki, a couple of months ago in our internal Slack, said:
[I would like] a debugging tool that checks that we're not missing any
fsyncs. I bumped into a few missing fsync bugs with unlogged tables
lately and a tool like that would
On Mon, 4 Dec 2023 at 22:03, Kirill Reshke wrote:
>
> On Mon, 4 Dec 2023 at 22:21, Matthias van de Meent
> wrote:
>>
>> On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote:
>> >
>> > So, 0002 patch uses the `get_tablespace` function, which searches Catalog
>> > to tablespace SMGR id. I wonder how
On Mon, 4 Dec 2023 at 22:21, Matthias van de Meent <
boekewurm+postg...@gmail.com> wrote:
> On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote:
> >
> > So, 0002 patch uses the `get_tablespace` function, which searches
> Catalog to tablespace SMGR id. I wonder how `smgr_redo` would work with it?
>
>
On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote:
>
> So, 0002 patch uses the `get_tablespace` function, which searches Catalog to
> tablespace SMGR id. I wonder how `smgr_redo` would work with it?
That's a very good point I hadn't considered in detail yet. Quite
clearly, the current code is wro
Sorry for double-posting, I accidentally replied to Matthias, not the
mailing list :(
-- Forwarded message -
From: Kirill Reshke
Date: Mon, 4 Dec 2023 at 19:46
Subject: Re: Extensible storage manager API - SMGR hook Redux
To: Matthias van de Meent
Hi!
On Fri, 30 Jun 2023 at
Found these warnings while compiling while only 0001 is applied.
[1166/2337] Compiling C object src/backend/postgres_lib.a.p/storage_smgr_md.c.o
../src/backend/storage/smgr/md.c: In function ‘mdexists’:
../src/backend/storage/smgr/md.c:224:28: warning: passing argument 1 of
‘mdopenfork’ from inc
> Subject: [PATCH v1 1/2] Expose f_smgr to extensions for manual implementation
>From what I can see, all the md* APIs that were exposed in md.h can now
be made static in md.c. The only other references to those APIs were in
smgr.c.
> Subject: [PATCH v1 2/2] Prototype: Allow tablespaces to specif
Hi,
On 2023-06-30 14:26:44 +0200, Matthias van de Meent wrote:
> diff --git a/src/backend/postmaster/postmaster.c
> b/src/backend/postmaster/postmaster.c
> index 4c49393fc5..8685b9fde6 100644
> --- a/src/backend/postmaster/postmaster.c
> +++ b/src/backend/postmaster/postmaster.c
> @@ -1002,6 +100
Hi hackers,
At Neon, we've been working on removing the file system dependency
from PostgreSQL and replacing it with a distributed storage layer. For
now, we've seen most success in this by replacing the implementation
of the smgr API, but it did require some core modifications like those
proposed
15 matches
Mail list logo
