Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-16 Thread Yugo Nagata
On Tue, 15 Jul 2025 19:07:16 +0900 Fujii Masao wrote: > I've pushed the patch. Thanks! Thank you! > > >>> But perhaps this corner case doesn't really > >>> need to be handled? > >> > >> Probably I failed to get your point here. Could you clarify what you meant? > > > > I'm sorry for not expla

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-15 Thread Fujii Masao
On 2025/07/10 14:11, Yugo Nagata wrote: On Thu, 10 Jul 2025 13:23:47 +0900 Fujii Masao wrote: On 2025/07/10 10:30, Yugo Nagata wrote: You're right. I must have overlooked something. I think I saw "TO" being suggested after "FOREIGN SERVER" when no foreign servers were defined. The attac

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-09 Thread Yugo Nagata
On Thu, 10 Jul 2025 13:23:47 +0900 Fujii Masao wrote: > > > On 2025/07/10 10:30, Yugo Nagata wrote: > > You're right. I must have overlooked something. I think I saw "TO" being > > suggested after "FOREIGN SERVER" when no foreign servers were defined. > > > > The attached patch still prevents

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-09 Thread Fujii Masao
On 2025/07/10 10:30, Yugo Nagata wrote: You're right. I must have overlooked something. I think I saw "TO" being suggested after "FOREIGN SERVER" when no foreign servers were defined. The attached patch still prevents "TO/FROM" from being suggested after "FOREIGN SERVER" in such cases. Than

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-09 Thread Yugo Nagata
On Wed, 9 Jul 2025 20:42:42 +0900 Fujii Masao wrote: > > > On 2025/06/11 13:57, Yugo Nagata wrote: > > On Wed, 11 Jun 2025 13:33:07 +0900 > > Fujii Masao wrote: > > > >> > >> > >> On 2025/06/11 11:49, Yugo Nagata wrote: > >>> While looking at the thread [1], I've remembered this thread. > >>>

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-07-09 Thread Fujii Masao
On 2025/06/11 13:57, Yugo Nagata wrote: On Wed, 11 Jun 2025 13:33:07 +0900 Fujii Masao wrote: On 2025/06/11 11:49, Yugo Nagata wrote: While looking at the thread [1], I've remembered this thread. The patches in this thread are partially v18-related, but include enhancement or fixes for e

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-06-10 Thread Yugo Nagata
On Wed, 11 Jun 2025 13:33:07 +0900 Fujii Masao wrote: > > > On 2025/06/11 11:49, Yugo Nagata wrote: > > While looking at the thread [1], I've remembered this thread. > > The patches in this thread are partially v18-related, but include > > enhancement or fixes for existing feature, so should th

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-06-10 Thread Yugo Nagata
On Wed, 11 Jun 2025 13:33:07 +0900 Fujii Masao wrote: > > > On 2025/06/11 11:49, Yugo Nagata wrote: > > While looking at the thread [1], I've remembered this thread. > > The patches in this thread are partially v18-related, but include > > enhancement or fixes for existing feature, so should th

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-06-10 Thread Fujii Masao
On 2025/06/11 11:49, Yugo Nagata wrote: While looking at the thread [1], I've remembered this thread. The patches in this thread are partially v18-related, but include enhancement or fixes for existing feature, so should they be postponed to v19, or should be separated properly to v18 part and

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-06-10 Thread Yugo Nagata
On Tue, 8 Apr 2025 12:28:57 +0900 Yugo NAGATA wrote: > On Fri, 4 Apr 2025 19:18:11 +0900 > Fujii Masao wrote: > > > > > > > On 2025/04/04 0:21, Fujii Masao wrote: > > > Thanks for updating the patch! > > > > > > If there are no objections, I'll proceed with committing it using the > > > fol

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-08 Thread Yugo NAGATA
On Fri, 4 Apr 2025 19:18:11 +0900 Fujii Masao wrote: > > > On 2025/04/04 0:21, Fujii Masao wrote: > > Thanks for updating the patch! > > > > If there are no objections, I'll proceed with committing it using the > > following commit log. > > I've pushed the patch. Thanks! Thank you! > Whi

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-04 Thread Fujii Masao
On 2025/04/04 23:47, Nathan Bossart wrote: On Fri, Apr 04, 2025 at 07:18:11PM +0900, Fujii Masao wrote: I've pushed the patch. Thanks! Just a heads up, I fixed a pgindent issue in this commit (see commits e1a8b1ad58 and 742317a80f). I'd ordinarily just report it, but since we're nearing fe

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-04 Thread Nathan Bossart
On Fri, Apr 04, 2025 at 07:18:11PM +0900, Fujii Masao wrote: > I've pushed the patch. Thanks! Just a heads up, I fixed a pgindent issue in this commit (see commits e1a8b1ad58 and 742317a80f). I'd ordinarily just report it, but since we're nearing feature freeze, I just fixed it because my workflo

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-04 Thread Fujii Masao
On 2025/04/04 0:21, Fujii Masao wrote: Thanks for updating the patch! If there are no objections, I'll proceed with committing it using the following commit log. I've pushed the patch. Thanks! While testing the feature, I noticed that psql doesn't complete "ALTER DEFAULT PRIVILEGES GRANT/R

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-03 Thread Fujii Masao
On 2025/04/03 23:04, Yugo NAGATA wrote: On Wed, 2 Apr 2025 02:35:35 +0900 Fujii Masao wrote: On 2025/01/23 19:22, Yugo NAGATA wrote: On Wed, 22 Jan 2025 13:30:17 +0100 Laurenz Albe wrote: On Fri, 2024-09-13 at 16:18 +0900, Yugo Nagata wrote: I've attached a updated patch. The test is

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-03 Thread Yugo NAGATA
ll, I like the idea. > > > The latest patch looks good to me. I just have one minor comment: > > > only the privileges for schemas, tables (including views and foreign > > tables), sequences, functions, and types (including domains) can be > > altered. > >

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-04-01 Thread Fujii Masao
On 2025/01/23 19:22, Yugo NAGATA wrote: On Wed, 22 Jan 2025 13:30:17 +0100 Laurenz Albe wrote: On Fri, 2024-09-13 at 16:18 +0900, Yugo Nagata wrote: I've attached a updated patch. The test is rewritten using has_largeobject_privilege() function instead of calling loread & lowrite, which m

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-01-23 Thread Yugo NAGATA
On Wed, 22 Jan 2025 13:30:17 +0100 Laurenz Albe wrote: > On Fri, 2024-09-13 at 16:18 +0900, Yugo Nagata wrote: > > I've attached a updated patch. The test is rewritten using > > has_largeobject_privilege() > > function instead of calling loread & lowrite, which makes the test a bit > > simpler.

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2025-01-22 Thread Laurenz Albe
r who thinks it worth the effort or not. Yours, Laurenz Albe From 55c0ed8c09b8bd83ced894a349c01f84b7c47e82 Mon Sep 17 00:00:00 2001 From: Laurenz Albe Date: Wed, 22 Jan 2025 13:15:27 +0100 Subject: [PATCH v4] Extend ALTER DEFAULT PRIVILEGES for large objects Previously, ALTER DEFAULT PRIVILEGE didn&#x

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-09-13 Thread Yugo Nagata
r changes. Regards, Yugo Nagata -- Yugo Nagata >From a27680b9f3031b0995fe20dd2d166e07a17ffeca Mon Sep 17 00:00:00 2001 From: Yugo Nagata Date: Fri, 8 Mar 2024 17:43:43 +0900 Subject: [PATCH v3] Extend ALTER DEFAULT PRIVILEGES for large objects Previously, ALTER DEFAULT PRIVILEGE didn'

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-05-02 Thread Yugo NAGATA
On Fri, 26 Apr 2024 12:23:45 +0200 Matthias van de Meent wrote: > On Fri, 26 Apr 2024 at 10:54, Yugo NAGATA wrote: > > > > On Wed, 24 Apr 2024 16:08:39 -0500 > > Nathan Bossart wrote: > > > > > On Tue, Apr 23, 2024 at 11:47:38PM -0400, Tom Lane wrote: > > > > On the whole I find this proposed f

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-26 Thread Matthias van de Meent
On Fri, 26 Apr 2024 at 10:54, Yugo NAGATA wrote: > > On Wed, 24 Apr 2024 16:08:39 -0500 > Nathan Bossart wrote: > > > On Tue, Apr 23, 2024 at 11:47:38PM -0400, Tom Lane wrote: > > > On the whole I find this proposed feature pretty unexciting > > > and dubiously worthy of the implementation/mainte

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-26 Thread Yugo NAGATA
On Wed, 24 Apr 2024 16:08:39 -0500 Nathan Bossart wrote: > On Tue, Apr 23, 2024 at 11:47:38PM -0400, Tom Lane wrote: > > On the whole I find this proposed feature pretty unexciting > > and dubiously worthy of the implementation/maintenance effort. > > I don't have any particularly strong feeling

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-24 Thread Nathan Bossart
On Tue, Apr 23, 2024 at 11:47:38PM -0400, Tom Lane wrote: > On the whole I find this proposed feature pretty unexciting > and dubiously worthy of the implementation/maintenance effort. I don't have any particularly strong feelings on $SUBJECT, but I'll admit I'd be much more interested in resolvin

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-23 Thread Yugo NAGATA
fb64d67779d5fcb8dab227 Mon Sep 17 00:00:00 2001 From: Yugo Nagata Date: Fri, 8 Mar 2024 17:43:43 +0900 Subject: [PATCH v2] Extend ALTER DEFAULT PRIVILEGES for large objects Original patch by Haruka Takatsuka, some fixes and tests by Yugo Nagata. --- doc/src/sgml/catalogs.sgml|

Re: Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-23 Thread Tom Lane
Yugo NAGATA writes: > Currently, ALTER DEFAULT PRIVILEGE doesn't support large objects, > so if we want to allow users other than the owner to use the large > object, we need to grant a privilege on it every time a large object > is created. One of our clients feels that this is annoying, so I wou

Extend ALTER DEFAULT PRIVILEGES for large objects

2024-04-23 Thread Yugo NAGATA
00:00:00 2001 From: Yugo Nagata Date: Fri, 8 Mar 2024 17:43:43 +0900 Subject: [PATCH] Extend ALTER DEFAULT PRIVILEGES for large objects Original patch by Haruka Takatsuka, some fixes and tests by Yugo Nagata. --- doc/src/sgml/catalogs.sgml| 3 +- .../sgml/ref/alter_default_pr