RE: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2025-01-09 Thread Regina Obe
> Regina Obe писал(а) 2025-01-03 23:08: > > I tested this with a patched version of the EDB PG 17 installer that > > includes this patch and it fixed the issue I was having described in: > > > > https://www.postgresql.org/message- > id/01db1df8%2449765bb0%24dc6313 > > 10%24%40pcorp.us > > > > I

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2025-01-09 Thread Vladlen Popolitov
Regina Obe писал(а) 2025-01-03 23:08: I tested this with a patched version of the EDB PG 17 installer that includes this patch and it fixed the issue I was having described in: https://www.postgresql.org/message-id/01db1df8%2449765bb0%24dc631310%24%40pcorp.us It would be great if this was

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2025-01-03 Thread Regina Obe
I tested this with a patched version of the EDB PG 17 installer that includes this patch and it fixed the issue I was having described in: https://www.postgresql.org/message-id/01db1df8%2449765bb0%24dc631310%24%40pcorp.us It would be great if this was backported to PG17. The new status of t

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-25 Thread Heikki Linnakangas
On 25/12/2024 18:34, Tom Lane wrote: Heikki Linnakangas writes: Ok, committed that, thanks1 The question this patch brings to my mind is whether libpgport doesn't need the same treatment. Good point. Yes it does. I tested that by adding a dummy call to COMP_CRC32C() in a test module, and

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-25 Thread Tom Lane
Heikki Linnakangas writes: > Ok, committed that, thanks1 The question this patch brings to my mind is whether libpgport doesn't need the same treatment. regards, tom lane

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-25 Thread Heikki Linnakangas
On 23/12/2024 14:16, Vladlen Popolitov wrote: Vladlen Popolitov писал(а) 2024-12-23 15:14:  Yes, it is also working option. I applied it and tested in the current master under Windows, it works. Attached patch changes this line in meson.build    link_with: cflag_libs, +  link_whole:

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
Vladlen Popolitov писал(а) 2024-12-23 15:14: Yes, it is also working option. I applied it and tested in the current master under Windows, it works. Attached patch changes this line in meson.build link_with: cflag_libs, + link_whole: cflag_libs, c_pch: pch_c_h, I also cre

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
Heikki Linnakangas писал(а) 2024-12-23 14:05: On 23/12/2024 12:32, Vladlen Popolitov wrote: I found the reason of this bug and the fix for it. Cool! Fortunatelly meson has option to force put all object files to library - add dependency with the flag link_whole . I made the one-line patch a

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Heikki Linnakangas
On 23/12/2024 12:32, Vladlen Popolitov wrote: I found the reason of this bug and the fix for it. Cool! Fortunatelly meson has option to force put all object files to library - add dependency with the flag link_whole . I made the one-line patch and it fixes this issue. -    'dependencies

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-12-23 Thread Vladlen Popolitov
Michael Paquier писал(а) 2024-09-14 03:15: On Fri, Sep 13, 2024 at 03:26:42PM -0700, Andrew Kane wrote: This was my hunch as well since none of the source files changed. Also, neither function is present with `dumpbin /EXPORTS /SYMBOLS lib\postgres.lib`, which led me to believe it may need to b

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Michael Paquier
On Fri, Sep 13, 2024 at 03:26:42PM -0700, Andrew Kane wrote: > This was my hunch as well since none of the source files changed. Also, > neither function is present with `dumpbin /EXPORTS /SYMBOLS > lib\postgres.lib`, which led me to believe it may need to be addressed > upstream. Hmm. Perhaps we

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Andrew Kane
> Probably a Windows thing? Correct, it's only on Windows. > I do see a fair amount of special handling for f2s.c in the build files. I wonder if something got broken for Windows in the switch from the MSVC scripts to meson. This was my hunch as well since none of the source files changed. Also

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Nathan Bossart
On Fri, Sep 13, 2024 at 04:58:20PM -0400, Tom Lane wrote: > Andrew Kane writes: >> With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and >> `float_to_shortest_decimal_bufn` are not longer exported. This causes >> `unresolved external symbol` linking errors for extensions that rely o

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Florents Tselai
> On 13 Sep 2024, at 11:07 PM, Andrew Kane wrote: > > Hi, > > With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and > `float_to_shortest_decimal_bufn` are not longer exported. This causes > `unresolved external symbol` linking errors for extensions that rely on these > funct

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Tom Lane
Andrew Kane writes: > With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and > `float_to_shortest_decimal_bufn` are not longer exported. This causes > `unresolved external symbol` linking errors for extensions that rely on > these functions (like pgvector). Can these functions be exp

Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

2024-09-13 Thread Andrew Kane
Hi, With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and `float_to_shortest_decimal_bufn` are not longer exported. This causes `unresolved external symbol` linking errors for extensions that rely on these functions (like pgvector). Can these functions be exported like previous vers