On Thu, Aug 14, 2025 at 9:43 AM Fujii Masao wrote:
>
> On Wed, Aug 13, 2025 at 1:00 PM Amit Kapila wrote:
> >
> > On Tue, Aug 12, 2025 at 4:28 PM Fujii Masao wrote:
> > >
> > > I'm not sure these messages are useful for end users, and LOG might not be
> > > the right level. They seem more like d
On Wed, Aug 13, 2025 at 1:00 PM Amit Kapila wrote:
>
> On Tue, Aug 12, 2025 at 4:28 PM Fujii Masao wrote:
> >
> > I'm not sure these messages are useful for end users, and LOG might not be
> > the right level. They seem more like debug information, so should we
> > consider
> > changing them to
On Wed, Aug 13, 2025 at 11:54 AM Amit Kapila wrote:
>
> On Tue, Aug 12, 2025 at 6:32 PM Fujii Masao wrote:
> >
> > Should we also update LOGICAL_REWRITE_FORMAT to use %08X?
> >
> > That said, the number of places to change is growing, and we're drifting
> > away from the original issue So I s
On Tue, Aug 12, 2025 at 4:28 PM Fujii Masao wrote:
>
> I'm not sure these messages are useful for end users, and LOG might not be
> the right level. They seem more like debug information, so should we consider
> changing them to DEBUG, even with the proposed patch applied?
>
Yeah, we can do that
On Tue, Aug 12, 2025 at 6:32 PM Fujii Masao wrote:
>
> Should we also update LOGICAL_REWRITE_FORMAT to use %08X?
>
> That said, the number of places to change is growing, and we're drifting
> away from the original issue So I started thinking it might be better
> to simply applying Shveta's pa
On Tue, Aug 12, 2025 at 10:02:32PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 8:06 PM Japin Li wrote:
> > OTOH, I also update reorder buffer spill file path.
> >
> > $ git grep -E 'xid-.*-lsn.*spill'
> > src/backend/replication/logical/reorderbuffer.c: snprintf(path, MAXPGPATH,
> > "%s/%
On Tue, Aug 12, 2025 at 8:06 PM Japin Li wrote:
>
> On Tue, Aug 12, 2025 at 07:14:38PM +0900, Fujii Masao wrote:
> > On Tue, Aug 12, 2025 at 6:25 PM Japin Li wrote:
> > > I believe that the format %X-%X also works with sscanf(). However, to
> > > maintain
> > > consistency, the format for sscanf
On Tue, Aug 12, 2025 at 07:58:25PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 7:14 PM Fujii Masao wrote:
> >
> > On Tue, Aug 12, 2025 at 6:25 PM Japin Li wrote:
> > > I believe that the format %X-%X also works with sscanf(). However, to
> > > maintain
> > > consistency, the format for s
On Tue, Aug 12, 2025 at 07:14:38PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 6:25 PM Japin Li wrote:
> > I believe that the format %X-%X also works with sscanf(). However, to
> > maintain
> > consistency, the format for sscanf() has been updated as well.
>
> Yes.
> Thanks for the patch
On Tue, Aug 12, 2025 at 7:14 PM Fujii Masao wrote:
>
> On Tue, Aug 12, 2025 at 6:25 PM Japin Li wrote:
> > I believe that the format %X-%X also works with sscanf(). However, to
> > maintain
> > consistency, the format for sscanf() has been updated as well.
>
> Yes.
> Thanks for the patch!
With
On Tue, Aug 12, 2025 at 6:25 PM Japin Li wrote:
> I believe that the format %X-%X also works with sscanf(). However, to maintain
> consistency, the format for sscanf() has been updated as well.
Yes.
Thanks for the patch!
Since we're changing the first "%X" in "%X-%X" to "%08X", the example
file
On Tue, Aug 12, 2025 at 05:57:45PM +0900, Fujii Masao wrote:
> On Tue, Aug 12, 2025 at 4:38 PM Japin Li wrote:
> >
> > On Tue, Aug 12, 2025 at 12:24:10PM +0530, shveta malik wrote:
> > > It looks like commit 2633dae (mistakenly) introduced a change ([1]) in
> > > SnapBuildSnapshotExists(), alterin
On Tue, Aug 12, 2025 at 4:38 PM Japin Li wrote:
>
> On Tue, Aug 12, 2025 at 12:24:10PM +0530, shveta malik wrote:
> > It looks like commit 2633dae (mistakenly) introduced a change ([1]) in
> > SnapBuildSnapshotExists(), altering the format used for snapshot file
> > names during the search. Howeve
On Tue, Aug 12, 2025 at 12:24:10PM +0530, shveta malik wrote:
> On Tue, Aug 12, 2025 at 8:52 AM Fujii Masao wrote:
> >
> > Hi,
> >
> > While testing the replication slot synchronization feature, I set up
> > three instances on the same machine:
> >
> > - Physical replication primary (also Logical
On Tue, Aug 12, 2025 at 8:52 AM Fujii Masao wrote:
>
> Hi,
>
> While testing the replication slot synchronization feature, I set up
> three instances on the same machine:
>
> - Physical replication primary (also Logical replication publisher)
> - Physical replication standby
> - Logical replicatio
Hi,
While testing the replication slot synchronization feature, I set up
three instances on the same machine:
- Physical replication primary (also Logical replication publisher)
- Physical replication standby
- Logical replication subscriber
initdb -D pri
16 matches
Mail list logo
