Re: Error logging messages

2022-04-14 Thread Daniel Gustafsson
> On 14 Apr 2022, at 16:32, Peter Eisentraut > wrote: > > On 13.04.22 13:51, Daniel Gustafsson wrote: >> 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error >> with a >> lowercase letter without punctuation. > > I'm having some doubts about some of these changes, especiall

Re: Error logging messages

2022-04-14 Thread Peter Eisentraut
On 13.04.22 13:51, Daniel Gustafsson wrote: 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with a lowercase letter without punctuation. I'm having some doubts about some of these changes, especially for interactive features in psql, where the messages are often use a

Re: Error logging messages

2022-04-14 Thread Daniel Gustafsson
> On 14 Apr 2022, at 09:10, Michael Paquier wrote: > > On Wed, Apr 13, 2022 at 01:51:16PM +0200, Daniel Gustafsson wrote: >> 0001: Makes sure that database and file names are printed quoted. This patch >> has hunks in contrib and backend as well. >> >> 0002: Capitalizes pg_log_error_detail and

Re: Error logging messages

2022-04-14 Thread Michael Paquier
On Wed, Apr 13, 2022 at 01:51:16PM +0200, Daniel Gustafsson wrote: > 0001: Makes sure that database and file names are printed quoted. This patch > has hunks in contrib and backend as well. > > 0002: Capitalizes pg_log_error_detail and conversely starts pg_log_error with > a > lowercase letter w

Error logging messages

2022-04-13 Thread Daniel Gustafsson
When reviewing the patch in "Frontend error logging style" [0] I noticed that some messages could do with a little bit of touching up. The original review was posted and responded to in that thread, but to keep goalposts in place it was put off until that patch had landed. To avoid this getting b