Re: Error in StrategySyncStart() prologue

2025-01-30 Thread Ashutosh Bapat
On Fri, Jan 31, 2025 at 7:38 AM Michael Paquier wrote: > > On Thu, Jan 30, 2025 at 05:36:32PM +0900, Michael Paquier wrote: > > Indeed, your suggestion sounds right. StrategySyncStart() is only > > used in BgBufferSync() for the background writer since 9cd00c457e6a, > > and this commit seems to h

Re: Error in StrategySyncStart() prologue

2025-01-30 Thread Michael Paquier
On Thu, Jan 30, 2025 at 05:36:32PM +0900, Michael Paquier wrote: > Indeed, your suggestion sounds right. StrategySyncStart() is only > used in BgBufferSync() for the background writer since 9cd00c457e6a, > and this commit seems to have missed the comment update. And done. -- Michael signature.a

Re: Error in StrategySyncStart() prologue

2025-01-30 Thread Michael Paquier
On Thu, Jan 30, 2025 at 11:04:19AM +0530, Ashutosh Bapat wrote: > The prologue of StrategySyncStart() mentions BufferSync(), but the > latter function does not call the first function. Instead > StrategySyncStart() is called by BgBufferSync() which uses the buffer > id provided by the first functio

Error in StrategySyncStart() prologue

2025-01-29 Thread Ashutosh Bapat
Hi, The prologue of StrategySyncStart() mentions BufferSync(), but the latter function does not call the first function. Instead StrategySyncStart() is called by BgBufferSync() which uses the buffer id provided by the first function to decide the buffer from where to start syncing as mentioned in t