Re: EphemeralNamedRelation and materialized view

2025-01-08 Thread Tom Lane
Yugo NAGATA writes: > Thank you for your reviewing and editing the patch! > I agree with your proposal on the error message handling. Cool, pushed v4 then. regards, tom lane

Re: EphemeralNamedRelation and materialized view

2025-01-08 Thread Yugo NAGATA
On Mon, 30 Dec 2024 16:06:06 -0500 Tom Lane wrote: > Yugo NAGATA writes: > > On Wed, 20 Nov 2024 12:43:16 -0500 > > Tom Lane wrote: > >> ... It seems to me that we should > >> think about this, for MVs as well as those other object types, > >> as fundamentally a dependency problem. That is, th

Re: EphemeralNamedRelation and materialized view

2024-12-30 Thread Tom Lane
Yugo NAGATA writes: > On Wed, 20 Nov 2024 12:43:16 -0500 > Tom Lane wrote: >> ... It seems to me that we should >> think about this, for MVs as well as those other object types, >> as fundamentally a dependency problem. That is, the reason >> we can't allow a reference to an ENR in a long-lived

Re: EphemeralNamedRelation and materialized view

2024-12-05 Thread Yugo NAGATA
On Wed, 20 Nov 2024 12:43:16 -0500 Tom Lane wrote: > Yugo NAGATA writes: > >> You could even argue that case 2 isn't good enough either, > >> and we should be delivering a specific error message saying > >> that an ENR can't be used in a view/matview. To do that, > >> we'd likely need to pass d

Re: EphemeralNamedRelation and materialized view

2024-11-29 Thread Kirill Reshke
On Fri, 15 Nov 2024 at 13:37, Yugo NAGATA wrote: > > On Sun, 03 Nov 2024 13:42:33 -0500 > Tom Lane wrote: > > > Yugo Nagata writes: > > > While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5, > > > I noticed that we can create a materialized view using Ephemeral Named > > > Rel

Re: EphemeralNamedRelation and materialized view

2024-11-20 Thread Tom Lane
Yugo NAGATA writes: >> You could even argue that case 2 isn't good enough either, >> and we should be delivering a specific error message saying >> that an ENR can't be used in a view/matview. To do that, >> we'd likely need to pass down the QueryEnvironment in more >> places not fewer. > We can

Re: EphemeralNamedRelation and materialized view

2024-11-17 Thread Michael Paquier
On Fri, Nov 15, 2024 at 05:36:47PM +0900, Yugo NAGATA wrote: > I agree that raising an internal error is not enough. I attached a updated > patch that outputs a message saying that an ENR can't be used in a matview. Hmm.. To get a better idea of the scope you are foreseeing here, should this incl

Re: EphemeralNamedRelation and materialized view

2024-11-15 Thread Yugo NAGATA
On Sun, 03 Nov 2024 13:42:33 -0500 Tom Lane wrote: > Yugo Nagata writes: > > While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5, > > I noticed that we can create a materialized view using Ephemeral Named > > Relation in PostgreSQL 16 or earler. > > Yeah, we should reject th

Re: EphemeralNamedRelation and materialized view

2024-11-03 Thread Tom Lane
Yugo Nagata writes: > While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5, > I noticed that we can create a materialized view using Ephemeral Named > Relation in PostgreSQL 16 or earler. Yeah, we should reject that, but I feel like this patch is not ambitious enough, because t

Re: EphemeralNamedRelation and materialized view

2024-08-10 Thread Kirill Reshke
On Fri, 26 Jul 2024 at 12:07, Yugo Nagata wrote: > > Hi, > > While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5, > I noticed that we can create a materialized view using Ephemeral Named > Relation in PostgreSQL 16 or earler. > > > postgres=# create table tbl (i int); > CREATE T

EphemeralNamedRelation and materialized view

2024-07-26 Thread Yugo Nagata
Hi, While looking into the commit b4da732fd64e936970f38c792f8b32c4bdf2bcd5, I noticed that we can create a materialized view using Ephemeral Named Relation in PostgreSQL 16 or earler. postgres=# create table tbl (i int); CREATE TABLE ^ postgr