On 2022-Jul-05, Robert Haas wrote:
> On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera wrote:
> > On 2022-Jun-29, Robert Haas wrote:
> > > Why?
> >
> > The reason is that errmsg() marks the message for translation, and we
> > don't want to burden translators with messages that are of little
> > inte
On Mon, Jul 4, 2022 at 5:27 AM Alvaro Herrera wrote:
> On 2022-Jun-29, Robert Haas wrote:
> > On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> > wrote:
> > > On 28.06.22 21:10, Jeff Davis wrote:
> > > > + ereport(DEBUG1, errmsg("executing extension script: %s",
> > > > filename));
> > >
>
On 2022-Jun-29, Robert Haas wrote:
> On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
> wrote:
> > On 28.06.22 21:10, Jeff Davis wrote:
> > > + ereport(DEBUG1, errmsg("executing extension script: %s", filename));
> >
> > This should either be elog or use errmsg_internal.
>
> Why?
The reason
On Fri, 2022-07-01 at 15:33 -0700, Nathan Bossart wrote:
> On Fri, Jul 01, 2022 at 03:24:27PM -0700, Jeff Davis wrote:
> > + ereport(DEBUG1, errmsg("executing extension update
> > script from version '%s' to '%s'", from_version, version));
>
> nitpick: I would suggest "executing extensio
On Fri, Jul 01, 2022 at 03:24:27PM -0700, Jeff Davis wrote:
> + ereport(DEBUG1, errmsg("executing extension update script from
> version '%s' to '%s'", from_version, version));
nitpick: I would suggest "executing extension script for update from
version X to Y."
I personally would ra
On Wed, 2022-06-29 at 21:39 -0400, Robert Haas wrote:
> > This should either be elog or use errmsg_internal.
>
> Why?
I didn't see a response, so I'm still using ereport(). I attached a new
version though that doesn't emit the actual script filename; instead
just the from/to version.
The output
On Wed, Jun 29, 2022 at 9:26 AM Peter Eisentraut
wrote:
> On 28.06.22 21:10, Jeff Davis wrote:
> > + ereport(DEBUG1, errmsg("executing extension script: %s", filename));
>
> This should either be elog or use errmsg_internal.
Why?
--
Robert Haas
EDB: http://www.enterprisedb.com
On 28.06.22 21:10, Jeff Davis wrote:
+ ereport(DEBUG1, errmsg("executing extension script: %s", filename));
This should either be elog or use errmsg_internal.
Patch attached.
Helpful for debugging complex extension script problems.
From b278eba9ba35ec1c52a8c1aa5c080a6731f86fbe Mon Sep 17 00:00:00 2001
From: Jeff Davis
Date: Tue, 28 Jun 2022 12:06:03 -0700
Subject: [PATCH] Emit debug message when executing extension script.
Outputting script filenames
