Re: ECPG regression with DECLARE STATEMENT support

2019-04-08 Thread Bruce Momjian
On Wed, Mar 13, 2019 at 04:35:48AM +, Matsumura, Ryo wrote: > Hi Kurokawa-san > > I reviewd it. It's ok. > I also confirm there is no same bug. FYI, this was applied a few weeks ago: Author: Michael Meskes Date: Fri Mar 15 22:35:24 2019 +0100 Use corre

RE: ECPG regression with DECLARE STATEMENT support

2019-03-12 Thread Matsumura, Ryo
Hi Kurokawa-san I reviewd it. It's ok. I also confirm there is no same bug. Regards Ryo Matsumura

RE: ECPG regression with DECLARE STATEMENT support

2019-03-12 Thread Kuroda, Hayato
Dear Matsumura-san, > I think that the 2nd argument of following ecpg_init() must be > real_connection_name. > Is it right? Yes, I think it should be real_connection_name for raising correct error message. This is also an leak of my code and I attached a patch. Best Regards, Hayato Kuroda Fu

RE: ECPG regression with DECLARE STATEMENT support

2019-03-12 Thread Matsumura, Ryo
Hi Kuroda-san I think that the 2nd argument of following ecpg_init() must be real_connection_name. Is it right? ECPGdeallocate(int lineno, int c, const char *connection_name, const char *name) : con = ecpg_get_connection(real_connection_name); if (!ecpg_init(con, connection_name, lineno)

Re: ECPG regression with DECLARE STATEMENT support

2019-03-11 Thread Michael Meskes
> I attached a simple bug-fixing patch. I'm not happy with the situation, but don't see a better solution either. Therefore I committed the change to get rid of the regression. Thanks. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Deb

RE: ECPG regression with DECLARE STATEMENT support

2019-03-10 Thread Kuroda, Hayato
Dear Rushabh, Michael, I attached a simple bug-fixing patch. Could you review it? An added logic is: 1. Send a close statement to a backend process regardless of the existence of a cursor. 2. If ecpg_do function returns false, raise “cursor is invalid” error. 3. Remove cursor from

RE: ECPG regression with DECLARE STATEMENT support

2019-03-07 Thread Kuroda, Hayato
Dear Rushabh, Michael, Thank you for reporting. I understood bugs had be embed in ecpg by me. I start checking codes and investigating solutions and other errors. Best Regards, Hayato Kuroda Fujitsu LIMITED

Re: ECPG regression with DECLARE STATEMENT support

2019-03-06 Thread Rushabh Lathia
On Thu, Mar 7, 2019 at 9:56 AM Michael Meskes wrote: > Hi, > > > Commit bd7c95f0c1a38becffceb3ea7234d57167f6d4bf add DECLARE > > STATEMENT support to ECPG. This introduced the new rule > > for EXEC SQL CLOSE cur and with that it gets transformed into > > ECPGclose(). > > > > Now prior to the abo

Re: ECPG regression with DECLARE STATEMENT support

2019-03-06 Thread Michael Meskes
Hi, > Commit bd7c95f0c1a38becffceb3ea7234d57167f6d4bf add DECLARE > STATEMENT support to ECPG. This introduced the new rule > for EXEC SQL CLOSE cur and with that it gets transformed into > ECPGclose(). > > Now prior to the above commit, someone can declare the > cursor in the SQL statement and

ECPG regression with DECLARE STATEMENT support

2019-03-05 Thread Rushabh Lathia
Hi, Commit bd7c95f0c1a38becffceb3ea7234d57167f6d4bf add DECLARE STATEMENT support to ECPG. This introduced the new rule for EXEC SQL CLOSE cur and with that it gets transformed into ECPGclose(). Now prior to the above commit, someone can declare the cursor in the SQL statement and "CLOSE cur_nam