Re: Duplicat-word typos in code comments

2021-10-05 Thread Daniel Gustafsson
> On 4 Oct 2021, at 21:54, Tom Lane wrote: > > Daniel Gustafsson writes: >>> On 4 Oct 2021, at 15:56, Tom Lane wrote: >>> I used to think it was better to go ahead and manually reflow, if you >>> use an editor that makes that easy. That way there are fewer commits >>> touching any one line of

Re: Duplicat-word typos in code comments

2021-10-04 Thread Tom Lane
Daniel Gustafsson writes: >> On 4 Oct 2021, at 15:56, Tom Lane wrote: >> I used to think it was better to go ahead and manually reflow, if you >> use an editor that makes that easy. That way there are fewer commits >> touching any one line of code, which is good when trying to review >> code his

Re: Duplicat-word typos in code comments

2021-10-04 Thread Daniel Gustafsson
> On 4 Oct 2021, at 15:56, Tom Lane wrote: > I used to think it was better to go ahead and manually reflow, if you > use an editor that makes that easy. That way there are fewer commits > touching any one line of code, which is good when trying to review > code history. However, now that we've

Re: Duplicat-word typos in code comments

2021-10-04 Thread Tom Lane
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > Daniel Gustafsson writes: >> I avoided the reflow of the comments though to make it the minimal >> change. > Fair enough. I wasn't sure myself whether to do it or not. The next pgindent run will do it anyway (except in comment blocks starting

Re: Duplicat-word typos in code comments

2021-10-04 Thread Dagfinn Ilmari Mannsåker
Daniel Gustafsson writes: >> On 4 Oct 2021, at 14:56, Dagfinn Ilmari Mannsåker wrote: > >> I noticed a duplicate-word typo in a comments recently, and cooked up >> the following ripgrep command to find some more. > > Pushed to master, thanks! Thanks! > I avoided the reflow of the comments thou

Re: Duplicat-word typos in code comments

2021-10-04 Thread Daniel Gustafsson
> On 4 Oct 2021, at 14:56, Dagfinn Ilmari Mannsåker wrote: > I noticed a duplicate-word typo in a comments recently, and cooked up > the following ripgrep command to find some more. Pushed to master, thanks! I avoided the reflow of the comments though to make it the minimal change. -- Daniel G

Duplicat-word typos in code comments

2021-10-04 Thread Dagfinn Ilmari Mannsåker
Hi hackers, I noticed a duplicate-word typo in a comments recently, and cooked up the following ripgrep command to find some more. rg --multiline --pcre2 --type=c '(?>From 7ed1ce16a37e7a63e7015cc4ef5b2b70ba915498 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= Date