Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-08 Thread Fujii Masao
On 2020/05/08 14:23, Fujii Masao wrote: On 2020/05/07 17:57, Amit Kapila wrote: On Thu, May 7, 2020 at 12:13 PM Fujii Masao wrote: On 2020/05/02 20:40, Amit Kapila wrote: I don't see any obvious problem with the changed code but we normally don't backpatch performance improvements.  I

Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-07 Thread Fujii Masao
On 2020/05/07 17:57, Amit Kapila wrote: On Thu, May 7, 2020 at 12:13 PM Fujii Masao wrote: On 2020/05/02 20:40, Amit Kapila wrote: I don't see any obvious problem with the changed code but we normally don't backpatch performance improvements. I can see that the code change here appears t

Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-07 Thread Amit Kapila
On Thu, May 7, 2020 at 12:13 PM Fujii Masao wrote: > > On 2020/05/02 20:40, Amit Kapila wrote: > > > > I don't see any obvious problem with the changed code but we normally > > don't backpatch performance improvements. I can see that the code > > change here appears to be straight forward so it m

Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-06 Thread Fujii Masao
On 2020/05/02 20:40, Amit Kapila wrote: On Thu, Apr 30, 2020 at 7:46 PM Fujii Masao wrote: On 2020/04/08 1:49, Fujii Masao wrote: On 2020/04/07 20:21, David Steele wrote: On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in This doesn'

Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-02 Thread Amit Kapila
On Thu, Apr 30, 2020 at 7:46 PM Fujii Masao wrote: > > On 2020/04/08 1:49, Fujii Masao wrote: > > > > > > On 2020/04/07 20:21, David Steele wrote: > >> > >> On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: > >>> At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao > >>> wrote in > >> This doesn't seem

Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-04-30 Thread Fujii Masao
On 2020/04/08 1:49, Fujii Masao wrote: On 2020/04/07 20:21, David Steele wrote: On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in This doesn't seem a bug, so I'm thinking to merge this to next *major* version release, i.e., v13. Not a

Re: Don't try fetching future segment of a TLI.

2020-04-07 Thread Fujii Masao
On 2020/04/07 20:21, David Steele wrote: On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in This doesn't seem a bug, so I'm thinking to merge this to next *major* version release, i.e., v13. Not a bug, perhaps, but I think we do consider b

Re: Don't try fetching future segment of a TLI.

2020-04-07 Thread David Steele
On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in This doesn't seem a bug, so I'm thinking to merge this to next *major* version release, i.e., v13. Not a bug, perhaps, but I think we do consider back-patching performance problems. The rise

Re: Don't try fetching future segment of a TLI.

2020-04-07 Thread Michael Paquier
On Tue, Apr 07, 2020 at 12:15:00PM +0900, Fujii Masao wrote: > I understood the situation and am fine to back-patch that. But I'm not sure > if it's fair to do that. Maybe we need to hear more opinions about this? > OTOH, feature freeze for v13 is today, so what about committing the patch > in v13

Re: Don't try fetching future segment of a TLI.

2020-04-07 Thread Kyotaro Horiguchi
At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao wrote in > > > On 2020/04/07 4:04, David Steele wrote: > > On 4/6/20 1:43 PM, Fujii Masao wrote: > >> > >> > >> On 2020/03/19 22:22, Pavel Suderevsky wrote: > >>> Hi, > >>> > >>> I've tested patch provided by Kyotaro and do confirm it fixes the >

Re: Don't try fetching future segment of a TLI.

2020-04-06 Thread Fujii Masao
On 2020/04/07 10:29, Kyotaro Horiguchi wrote: Thank you for picking this up. At Tue, 7 Apr 2020 02:43:02 +0900, Fujii Masao wrote in On 2020/03/19 22:22, Pavel Suderevsky wrote: Hi, I've tested patch provided by Kyotaro and do confirm it fixes the issue. The patch looks good to me. Attac

Re: Don't try fetching future segment of a TLI.

2020-04-06 Thread Fujii Masao
On 2020/04/07 4:04, David Steele wrote: On 4/6/20 1:43 PM, Fujii Masao wrote: On 2020/03/19 22:22, Pavel Suderevsky wrote: Hi, I've tested patch provided by Kyotaro and do confirm it fixes the issue. The patch looks good to me. Attached is the updated version of the patch. I updated onl

Re: Don't try fetching future segment of a TLI.

2020-04-06 Thread Kyotaro Horiguchi
Thank you for picking this up. At Tue, 7 Apr 2020 02:43:02 +0900, Fujii Masao wrote in > On 2020/03/19 22:22, Pavel Suderevsky wrote: > > Hi, > > I've tested patch provided by Kyotaro and do confirm it fixes the > > issue. > > The patch looks good to me. Attached is the updated version of the

Re: Don't try fetching future segment of a TLI.

2020-04-06 Thread David Steele
On 4/6/20 1:43 PM, Fujii Masao wrote: On 2020/03/19 22:22, Pavel Suderevsky wrote: Hi, I've tested patch provided by Kyotaro and do confirm it fixes the issue. The patch looks good to me. Attached is the updated version of the patch. I updated only comments. Barring any objection, I will c

Re: Don't try fetching future segment of a TLI.

2020-04-06 Thread Fujii Masao
On 2020/03/19 22:22, Pavel Suderevsky wrote: Hi, I've tested patch provided by Kyotaro and do confirm it fixes the issue. The patch looks good to me. Attached is the updated version of the patch. I updated only comments. Barring any objection, I will commit this patch. Any chance it will

Re: Don't try fetching future segment of a TLI.

2020-03-19 Thread Pavel Suderevsky
Hi, I've tested patch provided by Kyotaro and do confirm it fixes the issue. Any chance it will be merged to one of the next minor releases? Thank you very much! сб, 1 февр. 2020 г. в 08:31, David Steele : > On 1/28/20 8:02 PM, Kyotaro Horiguchi wrote: > > At Tue, 28 Jan 2020 19:13:32 +0300, P

Re: Don't try fetching future segment of a TLI.

2020-01-31 Thread David Steele
On 1/28/20 8:02 PM, Kyotaro Horiguchi wrote: > At Tue, 28 Jan 2020 19:13:32 +0300, Pavel Suderevsky >> Regading influence: issue is not about the large amount of WALs to apply >> but in searching for the non-existing WALs on the remote storage, each such >> search can take 5-10 seconds while obt

Don't try fetching future segment of a TLI.

2020-01-28 Thread Kyotaro Horiguchi
Hello, I added (moved to) -hackers. At Tue, 28 Jan 2020 19:13:32 +0300, Pavel Suderevsky wrote in > But for me it still seems that PostgreSQL has enough information to check > that no WALs exist for the new timeline to omit searching all the > possibly-existing WALs. > > It can just look throu