Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-05-01 Thread Robert Treat
On Thu, May 1, 2025 at 3:22 AM Peter Eisentraut wrote: > On 30.04.25 17:17, Robert Treat wrote: > > But otherwise this LGTM. > > Thanks, I have worked this into the commit. I wanted to get away from > phrases like "needs to be rebuilt" or "must be rebuilt" because that > possibly sounds like you

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-05-01 Thread Peter Eisentraut
On 30.04.25 17:17, Robert Treat wrote: On Wed, Apr 30, 2025 at 5:15 AM Peter Eisentraut wrote: On 28.04.25 18:56, Álvaro Herrera wrote: On 2025-Apr-23, Nathan Bossart wrote: On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote: I'd add a note about these two things to the open

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-04-30 Thread Robert Treat
On Wed, Apr 30, 2025 at 5:15 AM Peter Eisentraut wrote: > > On 28.04.25 18:56, Álvaro Herrera wrote: > > On 2025-Apr-23, Nathan Bossart wrote: > > > >> On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote: > > > >>> I'd add a note about these two things to the open items page, and wait >

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-04-30 Thread Peter Eisentraut
On 28.04.25 18:56, Álvaro Herrera wrote: On 2025-Apr-23, Nathan Bossart wrote: On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote: I'd add a note about these two things to the open items page, and wait to see if we get some of these limitations fixed, so that if we don't, we reme

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-04-28 Thread Álvaro Herrera
On 2025-Apr-23, Nathan Bossart wrote: > On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote: > > I'd add a note about these two things to the open items page, and wait > > to see if we get some of these limitations fixed, so that if we don't, > > we remember to note this limitation in

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-04-23 Thread Nathan Bossart
This one was briefly discussed in an RMT meeting. On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote: > On 2025-Mar-24, jian he wrote: > >> In the current development branch, >> virtual generated columns still do not support the domain. >> you can not change the generation expression

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-03-24 Thread Álvaro Herrera
On 2025-Mar-24, jian he wrote: > In the current development branch, > virtual generated columns still do not support the domain. > you can not change the generation expression if it contains a check > constraint on it. > so virtual generated columns don't need rewriting. > > IMHO, the committed d

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-03-23 Thread jian he
hi. https://git.postgresql.org/cgit/postgresql.git/commit/?id=11bd8318602fc2282a6201f714c15461dc2009c6 + Adding a column with a volatile DEFAULT + (e.g., clock_timestamp()), a generated column + (e.g., GENERATED BY DEFAULT AS IDENTITY), a domain + data type with constraints will require the entir

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-03-14 Thread Álvaro Herrera
Hello, I have pushed this patch now, with some tiny changes. (I am not a believer of the semicolon added by commit d31e2a495b6f before the word "and"). Also, I didn't think that changing a column type was sufficiently close to the restrictions of column addition to belong in the same enumeration

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-01-06 Thread Masahiro Ikeda
On 2025-01-07 06:27, Robert Treat wrote: On Mon, Jan 6, 2025 at 3:18 AM Masahiro Ikeda wrote: On 2025-01-03 01:25, Robert Treat wrote: > On Tue, Dec 3, 2024 at 3:13 AM Masahiro Ikeda > wrote: >> >> Hi, >> >> The documentation seems to overlook the rewrite condition >> when executing ALTER TAB

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-01-06 Thread Robert Treat
On Mon, Jan 6, 2025 at 3:18 AM Masahiro Ikeda wrote: > > On 2025-01-03 01:25, Robert Treat wrote: > > On Tue, Dec 3, 2024 at 3:13 AM Masahiro Ikeda > > wrote: > >> > >> Hi, > >> > >> The documentation seems to overlook the rewrite condition > >> when executing ALTER TABLE ADD COLUMN. > >> > >> Th

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-01-06 Thread Masahiro Ikeda
On 2025-01-03 01:25, Robert Treat wrote: On Tue, Dec 3, 2024 at 3:13 AM Masahiro Ikeda wrote: Hi, The documentation seems to overlook the rewrite condition when executing ALTER TABLE ADD COLUMN. The current document states that a volatile DEFAULT will trigger a rewrite of the table and its i

Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2025-01-02 Thread Robert Treat
On Tue, Dec 3, 2024 at 3:13 AM Masahiro Ikeda wrote: > > Hi, > > The documentation seems to overlook the rewrite condition > when executing ALTER TABLE ADD COLUMN. > > The current document states that a volatile DEFAULT will > trigger a rewrite of the table and its indexes. However, the > table an

Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

2024-12-03 Thread Masahiro Ikeda
024-12-03 15:08:24.261445 | 34 | 8 | | 18 | | 100 | 2024-12-03 15:08:24.251233 | 2024-12-03 15:08:24.261448 | 36 | 9 | | 19 | | 100 | 2024-12-03 15:08:24.251233 | 2024-12-03 15:08:24.26145 | 38 | 10 | | (10 rows) From 94b79dc0f6412b1e73549c091d6561e0815d07d3 Mon Sep