Re: Do away with a few backwards compatibility macros

2023-11-27 Thread Nathan Bossart
On Mon, Nov 27, 2023 at 04:29:18PM +0530, Bharath Rupireddy wrote: > I think it's easy to miss/enforce a documented policy. IMV, moving > towards pg_attribute_deprecated as Alvaro Herrera said in the other > thread > https://www.postgresql.org/message-id/202311141920.edtj56saukiv%40alvherre.pgsql

Re: Do away with a few backwards compatibility macros

2023-11-27 Thread Bharath Rupireddy
On Tue, Nov 21, 2023 at 9:22 PM Nathan Bossart wrote: > > On Tue, Nov 21, 2023 at 12:05:36AM -0500, Tom Lane wrote: > > No objection here, but should we try to establish some sort of project > > policy around this sort of change (ie, removal of backwards-compatibility > > support)? "Once it no lo

Re: Do away with a few backwards compatibility macros

2023-11-21 Thread Nathan Bossart
On Tue, Nov 21, 2023 at 12:05:36AM -0500, Tom Lane wrote: > No objection here, but should we try to establish some sort of project > policy around this sort of change (ie, removal of backwards-compatibility > support)? "Once it no longer matters for any supported version" sounds > about right to m

Re: Do away with a few backwards compatibility macros

2023-11-20 Thread Tom Lane
Nathan Bossart writes: > On Thu, Nov 16, 2023 at 09:46:22AM -0600, Nathan Bossart wrote: >> I'm fine with this because all of these macros are no-ops for all supported >> versions of Postgres. Even if an extension is using them today, you'll get >> the same behavior as before if you remove the us

Re: Do away with a few backwards compatibility macros

2023-11-20 Thread Nathan Bossart
On Thu, Nov 16, 2023 at 09:46:22AM -0600, Nathan Bossart wrote: > On Thu, Nov 16, 2023 at 07:11:41PM +0530, Bharath Rupireddy wrote: >> After a recent commit 6a72c42f (a related discussion [1]) which >> removed MemoryContextResetAndDeleteChildren(), I think there are a >> couple of other backward c

Re: Do away with a few backwards compatibility macros

2023-11-16 Thread Nathan Bossart
On Thu, Nov 16, 2023 at 07:11:41PM +0530, Bharath Rupireddy wrote: > After a recent commit 6a72c42f (a related discussion [1]) which > removed MemoryContextResetAndDeleteChildren(), I think there are a > couple of other backward compatibility macros out there that can be > removed. These macros are

Do away with a few backwards compatibility macros

2023-11-16 Thread Bharath Rupireddy
Hi, After a recent commit 6a72c42f (a related discussion [1]) which removed MemoryContextResetAndDeleteChildren(), I think there are a couple of other backward compatibility macros out there that can be removed. These macros are tuplestore_donestoring() which was introduced by commit dd04e95 21 ye