Re: Deduplicate min restart_lsn calculation code

2022-01-06 Thread Bharath Rupireddy
On Thu, Jan 6, 2022 at 11:54 PM Alvaro Herrera wrote: > > On 2022-Jan-06, Bharath Rupireddy wrote: > > > Hi, > > > > It seems like the two functions ReplicationSlotsComputeRequiredLSN and > > ReplicationSlotsComputeLogicalRestartLSN more or less does the same > > thing which makes me optimize (sav

Re: Deduplicate min restart_lsn calculation code

2022-01-06 Thread Alvaro Herrera
On 2022-Jan-06, Bharath Rupireddy wrote: > Hi, > > It seems like the two functions ReplicationSlotsComputeRequiredLSN and > ReplicationSlotsComputeLogicalRestartLSN more or less does the same > thing which makes me optimize (saving 40 LOC) it as attached. I'm > pretty much okay if it gets rejecte

Deduplicate min restart_lsn calculation code

2022-01-06 Thread Bharath Rupireddy
Hi, It seems like the two functions ReplicationSlotsComputeRequiredLSN and ReplicationSlotsComputeLogicalRestartLSN more or less does the same thing which makes me optimize (saving 40 LOC) it as attached. I'm pretty much okay if it gets rejected on the grounds that it creates a lot of diff with th