Ashwin Agrawal writes:
> Do we wish to make this a tool and have it in src/tools, either as part of
> find_static tool after renaming that one to more generic name or
> independent script.
Well, the scripts described so far are little more than jury-rigged
hacks, with lots of room for false posit
On Sat, Jul 6, 2019 at 4:32 PM Masahiko Sawada
wrote:
> Indeed. I've tried to search again with the following script and got
> more such functions.
>
> for func in `git ls-files | egrep "\w+\.h$" | xargs cat | egrep -v
> "(^typedef)|(DECLARE)|(BKI)" | egrep "^(extern )*[\_0-9A-Za-z]+
> [\_\*0-9a-
On Sun, Jul 7, 2019 at 10:04 AM Michael Paquier wrote:
>
> On Sun, Jul 07, 2019 at 07:31:12AM +0800, Masahiko Sawada wrote:
> > Attached patch removes these functions.
>
> Thanks, applied.
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software
On Sun, Jul 07, 2019 at 07:31:12AM +0800, Masahiko Sawada wrote:
> Attached patch removes these functions.
Thanks, applied.
--
Michael
signature.asc
Description: PGP signature
On Sat, Jul 6, 2019 at 7:32 AM Tom Lane wrote:
>
> Masahiko Sawada writes:
> > I think the following functions are mistakenly left in the header
> > file. So attached patch removes them.
>
> > dsa_startup()
> > TransactionIdAbort()
> > renameatt_type()
>
> Agreed, these are referenced nowhere. I
Masahiko Sawada writes:
> I think the following functions are mistakenly left in the header
> file. So attached patch removes them.
> dsa_startup()
> TransactionIdAbort()
> renameatt_type()
Agreed, these are referenced nowhere. I pushed the patch.
> I realized that TransactionIdAbort is declar
Hi,
I realized that TransactionIdAbort is declared in the transam.h but
there is not its function body. As far as I found there are three
similar functions in total by the following script.
for func in `git ls-files | egrep "\w+\.h$" | xargs cat | egrep
"extern \w+ \w+\(.*\);" | sed -e "s/.* \(.*
