Re: DSA overflow in hash join

2025-10-18 Thread Tomas Vondra
Hi, I did look at this because of the thread about "nbatch overflow" [1]. And the patches I just posted in that thread resolve the issue for me, in the sense that the reproducer [2] no longer fails for me. But I think that's actually mostly an accident - the balancing reduces nbatch, exchanging i

Re: DSA overflow in hash join

2025-08-16 Thread Konstantin Knizhnik
Thank you for review! On 14/08/2025 10:34 PM, Heikki Linnakangas wrote: On 31/07/2025 18:13, Konstantin Knizhnik wrote: On 27/07/2025 8:24 PM, Konstantin Knizhnik wrote: I still trying to understand the reason of DSA overflow in hash join. In addition to two suspicious places where number

Re: DSA overflow in hash join

2025-08-14 Thread Heikki Linnakangas
On 31/07/2025 18:13, Konstantin Knizhnik wrote: On 27/07/2025 8:24 PM, Konstantin Knizhnik wrote: I still trying to understand the reason of DSA overflow in hash join. In addition to two suspicious places where number of buckets is doubled without chek for overflow (nodeHash.c:1668 and

Re: DSA overflow in hash join

2025-07-31 Thread Konstantin Knizhnik
On 27/07/2025 8:24 PM, Konstantin Knizhnik wrote: I still trying to understand the reason of DSA overflow in hash join. In addition to two suspicious places where number of buckets is doubled without chek for overflow (nodeHash.c:1668 and nodeHash.c:3290), there is one  more place  where

Re: DSA overflow in hash join

2025-07-27 Thread Konstantin Knizhnik
I still trying to understand the reason of DSA overflow in hash join. In addition to two suspicious places where number of buckets is doubled without chek for overflow (nodeHash.c:1668 and nodeHash.c:3290), there is one  more place  where number of batches is multiplied by

DSA overflow in hash join

2025-07-20 Thread Konstantin Knizhnik
Hi hackers! There is weird error rarely reproduced with sqlancer: `ERROR: invalid DSA memory alloc request size 1140850688`: ** *-* * FinalizeAggregate(cost=114075075706156