On Tue, Nov 19, 2024 at 1:26 AM Bruce Momjian wrote:
>
> On Mon, Nov 18, 2024 at 01:31:45PM +0530, Amit Kapila wrote:
> > On Mon, Nov 18, 2024 at 12:24 PM Nisha Moond
> > wrote:
> > >
> > > Attached the patch with modification.
> > >
> >
> > Looks reasonable to me.
>
> +1
>
Pushed.
--
With Re
On Mon, Nov 18, 2024 at 01:31:45PM +0530, Amit Kapila wrote:
> On Mon, Nov 18, 2024 at 12:24 PM Nisha Moond wrote:
> > -- inactive_since will be reset to NULL by the process that acquires
> > the slot, making it active or in-use again.
> >
> > AFAIU, inactive_since indicates the point in time when
On Fri, Nov 15, 2024 at 3:01 PM Amit Kapila wrote:
>
> On Thu, Nov 14, 2024 at 12:12 PM Nisha Moond wrote:
> >
> > On Thu, Oct 31, 2024 at 11:05 PM Bruce Momjian wrote:
> > >
> > >
> > > Yes, all good suggestions, updated patch attached.
> > >
> >
> > Few comments for the changes under "inactive
On Mon, Nov 18, 2024 at 12:24 PM Nisha Moond wrote:
>
> On Fri, Nov 15, 2024 at 3:01 PM Amit Kapila wrote:
> >
> > On Thu, Nov 14, 2024 at 12:12 PM Nisha Moond
> > wrote:
> > >
> > > On Thu, Oct 31, 2024 at 11:05 PM Bruce Momjian wrote:
> > > >
> > > >
> > > > Yes, all good suggestions, update
On Thu, Nov 14, 2024 at 12:12 PM Nisha Moond wrote:
>
> On Thu, Oct 31, 2024 at 11:05 PM Bruce Momjian wrote:
> >
> >
> > Yes, all good suggestions, updated patch attached.
> >
>
> Few comments for the changes under "inactive_since" description:
>
> +The time when slot synchronization (se
On Thu, Oct 31, 2024 at 11:05 PM Bruce Momjian wrote:
>
>
> Yes, all good suggestions, updated patch attached.
>
Few comments for the changes under "inactive_since" description:
+The time when slot synchronization (see )
+was most recently stopped. NULL if the slot
+has
On Thu, Oct 31, 2024 at 11:05 PM Bruce Momjian wrote:
>
> Yes, all good suggestions, updated patch attached.
>
LGTM.
--
With Regards,
Amit Kapila.
On Thu, Oct 24, 2024 at 08:32:54AM +1100, Peter Smith wrote:
> Hi. Here are a couple of minor comments.
>
> 1.
> +The time slot synchronization (see +linkend="logicaldecoding-replication-slots-synchronization"/>)
> +was most recently stopped.
>
> /The time slot/The time w
On Fri, Oct 18, 2024 at 04:25:33PM +0530, Amit Kapila wrote:
> Few comments:
> =
> 1.
>
> - True if this slot is currently actively being used
> + True if this slot is currently currently being streamed
>
>
> currently shouldn't be used twice.
>
> 2.
> - /* The ti
Hi. Here are a couple of minor comments.
1.
+The time slot synchronization (see )
+was most recently stopped.
/The time slot/The time when slot/
~~~
2.
- /* The time since the slot has become inactive */
+ /* The time slot sychronized was stopped. */
Maybe just make this comme
On Wed, Oct 16, 2024 at 10:56 PM Bruce Momjian wrote:
>
> On Mon, Sep 9, 2024 at 01:15:32PM +1000, Peter Smith wrote:
> >
> > Me too. I created this thread primarily to get the description changed
> > to clarify this field represents a moment in time, rather than a
> > duration. So I will be happ
On Mon, Sep 9, 2024 at 01:15:32PM +1000, Peter Smith wrote:
> On Mon, Sep 9, 2024 at 12:20 PM David G. Johnston
> wrote:
> >
> >
> >
> > On Sun, Sep 8, 2024, 18:55 Peter Smith wrote:
> >>
> >> Saying "The time..." is fine, but the suggestions given seem backwards to
> >> me:
> >> - The time thi
On Mon, Sep 9, 2024 at 12:20 PM David G. Johnston
wrote:
>
>
>
> On Sun, Sep 8, 2024, 18:55 Peter Smith wrote:
>>
>> Saying "The time..." is fine, but the suggestions given seem backwards to me:
>> - The time this slot was inactivated
>> - The time when the slot became inactive.
>> - The time whe
On Sun, Sep 8, 2024, 18:55 Peter Smith wrote:
> Saying "The time..." is fine, but the suggestions given seem backwards to
> me:
> - The time this slot was inactivated
> - The time when the slot became inactive.
> - The time when the slot was deactivated.
>
> e.g. It is not like light switch. So,
Saying "The time..." is fine, but the suggestions given seem backwards to me:
- The time this slot was inactivated
- The time when the slot became inactive.
- The time when the slot was deactivated.
e.g. It is not like light switch. So, there is no moment when the
active slot "became inactive" or
On Wed, Sep 4, 2024 at 11:34 AM David G. Johnston
wrote:
>
>
> Agree on sticking with “The time…”
>
> Thus I suggest either:
>
> The time when the slot became inactive.
+1. Definitely removes confusion caused by "since" and keeps The time
as subject.
--
Best Wishes,
Ashutosh Bapat
On Tuesday, September 3, 2024, Kyotaro Horiguchi
wrote:
> At Tue, 3 Sep 2024 10:43:14 +0530, Amit Kapila
> wrote in
> > On Mon, Sep 2, 2024 at 9:14 AM shveta malik
> wrote:
> > >
> > > On Mon, Sep 2, 2024 at 5:47 AM Peter Smith
> wrote:
> > > >
> > > >
> > > > To summarize, the current de
At Tue, 3 Sep 2024 10:43:14 +0530, Amit Kapila wrote
in
> On Mon, Sep 2, 2024 at 9:14 AM shveta malik wrote:
> >
> > On Mon, Sep 2, 2024 at 5:47 AM Peter Smith wrote:
> > >
> > >
> > > To summarize, the current description wrongly describes the field as a
> > > time duration:
> > > "The t
On Tue, Sep 3, 2024 at 4:12 PM shveta malik wrote:
>
...
> Shall we make the change in code-comment as well:
>
> typedef struct ReplicationSlot
> {
> ...
> /* The time since the slot has become inactive */
> TimestampTz inactive_since;
> }
>
Hi Shveta,
Yes, I think so. I hadn't b
Hi,
On Tue, Sep 03, 2024 at 05:52:53PM +1000, Peter Smith wrote:
> On Tue, Sep 3, 2024 at 4:35 PM Bertrand Drouvot
> wrote:
> >
> > Hi,
> >
> > On Tue, Sep 03, 2024 at 10:43:14AM +0530, Amit Kapila wrote:
> > > On Mon, Sep 2, 2024 at 9:14 AM shveta malik
> > > wrote:
> > > >
> > > > On Mon, Sep
On Tue, Sep 3, 2024 at 4:35 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Tue, Sep 03, 2024 at 10:43:14AM +0530, Amit Kapila wrote:
> > On Mon, Sep 2, 2024 at 9:14 AM shveta malik wrote:
> > >
> > > On Mon, Sep 2, 2024 at 5:47 AM Peter Smith wrote:
> > > >
> > > >
> > > > To summarize, the curr
Hi,
On Tue, Sep 03, 2024 at 10:43:14AM +0530, Amit Kapila wrote:
> On Mon, Sep 2, 2024 at 9:14 AM shveta malik wrote:
> >
> > On Mon, Sep 2, 2024 at 5:47 AM Peter Smith wrote:
> > >
> > >
> > > To summarize, the current description wrongly describes the field as a
> > > time duration:
> > >
On Tue, Sep 3, 2024 at 10:43 AM Amit Kapila wrote:
>
> > >
> > > To summarize, the current description wrongly describes the field as a
> > > time duration:
> > > "The time since the slot has become inactive."
> > >
> > > I suggest replacing it with:
> > > "The slot has been inactive since this ti
On Mon, Sep 2, 2024 at 9:14 AM shveta malik wrote:
>
> On Mon, Sep 2, 2024 at 5:47 AM Peter Smith wrote:
> >
> >
> > To summarize, the current description wrongly describes the field as a
> > time duration:
> > "The time since the slot has become inactive."
> >
> > I suggest replacing it wit
On Mon, Sep 2, 2024 at 5:47 AM Peter Smith wrote:
>
> Hi hackers. While reviewing another thread I had cause to look at the
> docs for the pg_replication_slot 'inactive_since' field [1] for the
> first time.
>
> I was confused by the description, which is as follows:
>
> inactive_since timest
Hi hackers. While reviewing another thread I had cause to look at the
docs for the pg_replication_slot 'inactive_since' field [1] for the
first time.
I was confused by the description, which is as follows:
inactive_since timestamptz
The time since the slot has become inactive. NULL if the slo
26 matches
Mail list logo
