Re: Copypasta in the PostgreSQL source

2018-12-17 Thread Thomas Munro
On Tue, Dec 18, 2018 at 9:46 AM Tom Lane wrote: > Alvaro Herrera writes: > > On the other hand, I'm not clear on why do we need four copies of > > number_of_ones. > > Yeah, it might be time to move something like that into a common > location. Not sure where the threshold of pain is, though. Ye

Re: Copypasta in the PostgreSQL source

2018-12-17 Thread Andres Freund
Hi, On 2018-12-18 00:36:55 +0100, David Fetter wrote: > On Mon, Dec 17, 2018 at 05:31:22PM -0500, Tom Lane wrote: > > David Fetter writes: > > > Please find attached a run of a tool that looks for duplicated > > > tokens. I've removed some things that seem like false positives, > > > basically a

Re: Copypasta in the PostgreSQL source

2018-12-17 Thread David Fetter
On Mon, Dec 17, 2018 at 05:31:22PM -0500, Tom Lane wrote: > David Fetter writes: > > Please find attached a run of a tool that looks for duplicated > > tokens. I've removed some things that seem like false positives, > > basically all from the stemmer part of the source, but there's > > still a l

Re: Copypasta in the PostgreSQL source

2018-12-17 Thread Tom Lane
Alvaro Herrera writes: > On the other hand, I'm not clear on why do we need four copies of > number_of_ones. Yeah, it might be time to move something like that into a common location. Not sure where the threshold of pain is, though. regards, tom lane

Re: Copypasta in the PostgreSQL source

2018-12-17 Thread Alvaro Herrera
On 2018-Dec-17, Tom Lane wrote: > David Fetter writes: > > Please find attached a run of a tool that looks for duplicated tokens. > > I've removed some things that seem like false positives, basically all > > from the stemmer part of the source, but there's still a lot. > > I thought you were ta

Re: Copypasta in the PostgreSQL source

2018-12-17 Thread Tom Lane
David Fetter writes: > Please find attached a run of a tool that looks for duplicated tokens. > I've removed some things that seem like false positives, basically all > from the stemmer part of the source, but there's still a lot. I thought you were talking about problems like "that that" typos,