Re: Contribution to Perldoc for TestLib module in Postgres

2019-09-02 Thread Michael Paquier
On Mon, Sep 02, 2019 at 01:48:14PM -0400, Alvaro Herrera wrote: > Agreed ... that's pretty much the same thing I tried to say upthread. I > wrote my own synopsis, partly using your suggestions. I reworded the > description for the routines (I don't think there's any I didn't touch), > added a men

Re: Contribution to Perldoc for TestLib module in Postgres

2019-09-02 Thread Alvaro Herrera
On 2019-Jul-30, Michael Paquier wrote: > I think that the SYNOPSIS could be shaped better. As of now it is a > simple succession of the same commands listed without any link to each > other, which is contrary for example to what we do in PostgresNode.pm, > where it shows up a set of small example

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-31 Thread Thomas Munro
On Tue, Jul 30, 2019 at 4:47 PM Michael Paquier wrote: > On Fri, Jul 26, 2019 at 09:51:34AM -0400, Andrew Dunstan wrote: > > I've fixed the bitrot and some other infelicities on this patch. It's > > not commitable yet but I think it's more reviewable. > > Thanks, I had a look at this version. > >

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-29 Thread Michael Paquier
On Fri, Jul 26, 2019 at 09:51:34AM -0400, Andrew Dunstan wrote: > I've fixed the bitrot and some other infelicities on this patch. It's > not commitable yet but I think it's more reviewable. Thanks, I had a look at this version. + # Returns the real directory for a virtual path directory under m

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-26 Thread Andrew Dunstan
On 7/10/19 9:38 AM, Alvaro Herrera wrote: > On 2019-Apr-11, Iwata, Aya wrote: > >> In the above document, why not write a description after the function name? >> I think it is better to write the function name first and then the >> description. >> In your code; >> #Checks if all the tests passe

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-10 Thread Alvaro Herrera
On 2019-Apr-11, Iwata, Aya wrote: > In the above document, why not write a description after the function name? > I think it is better to write the function name first and then the > description. > In your code; > #Checks if all the tests passed or not > all_tests_passing() > > In my suggesti

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-10 Thread Michael Paquier
On Tue, Jul 09, 2019 at 03:16:01PM +0200, Daniel Gustafsson wrote: > The v2 patch is somewhat confused as it has Windows carriage returns rather > than newlines, so it replaces the entire file making the diff hard to read. > It > also includes a copy of TestLib and the v1 patch and has a lot of w

Re: Contribution to Perldoc for TestLib module in Postgres

2019-07-09 Thread Daniel Gustafsson
> On 7 Apr 2019, at 20:04, Ramanarayana wrote: > Please find the updated patch. Added to the commitfest as well The v2 patch is somewhat confused as it has Windows carriage returns rather than newlines, so it replaces the entire file making the diff hard to read. It also includes a copy of Test

RE: Contribution to Perldoc for TestLib module in Postgres

2019-04-10 Thread Iwata, Aya
Hi Ram, I think this documentation helps people who want to understand functions. >Please find the updated patch. Added to the commitfest as well I have some comments. I think some users who would like to know custom function check src/test/perl/README at first. How about add comments to the REA

Re: Contribution to Perldoc for TestLib module in Postgres

2019-04-07 Thread Ramanarayana
Hi, Please find the updated patch. Added to the commitfest as well Regards, Ram. v2_perldoc_testlib.patch.patch Description: Binary data

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-22 Thread Michael Paquier
On Fri, Mar 22, 2019 at 04:59:58PM +0530, Ramanarayana wrote: > Please find the first version of the patch for review. I was not sure what > some of the functions are used for and marked them with TODO. This is only adding some documentation to an internal perl module we ship, so it is far from be

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-22 Thread Ramanarayana
Hi, Please find the first version of the patch for review. I was not sure what some of the functions are used for and marked them with TODO. Cheers Ram 4.0 v1_perldoc_testlib.patch Description: Binary data

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-21 Thread Prajwal A V
Sure, please go ahead. Regards, Prajwal. On Thu, 21 Mar 2019, 19:11 Ramanarayana, wrote: > Hi, > Can I take this up? > > Regards, > Ram >

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-21 Thread Ramanarayana
Hi, Can I take this up? Regards, Ram

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-19 Thread Michael Paquier
On Tue, Mar 19, 2019 at 09:05:29AM -0300, Alvaro Herrera wrote: > Yes, it is, please do. +1. -- Michael signature.asc Description: PGP signature

Re: Contribution to Perldoc for TestLib module in Postgres

2019-03-19 Thread Alvaro Herrera
On 2019-Mar-19, Prajwal A V wrote: > I could not find the perldoc for TestLib module in src/test/perl and found > some difficultly in understanding what each function does while other > modules in the src/test folder had perldoc and it was easy to understand > the functions. > > I would like to c

Contribution to Perldoc for TestLib module in Postgres

2019-03-19 Thread Prajwal A V
Hi Hackers, I was going through the regression testing framework used in postgres. I was trying to understand the custom functions written in perl for postgres. I could not find the perldoc for TestLib module in src/test/perl and found some difficultly in understanding what each function does whi