Re: Consolidate ItemPointer to Datum conversion functions

2023-02-13 Thread Peter Eisentraut
On 09.02.23 09:33, Peter Eisentraut wrote: On 06.02.23 11:11, Heikki Linnakangas wrote: On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file.  In passing, convert to inline functions. Looks good to

Re: Consolidate ItemPointer to Datum conversion functions

2023-02-09 Thread Peter Eisentraut
From 47b316eb6cfa50412d81fd183a8b54e0a104a685 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 9 Feb 2023 09:23:20 +0100 Subject: [PATCH v2] Consolidate ItemPointer to Datum conversion functions Instead of defining the same set of macros several times, define it once in an appropriate header file. In passing, conve

Re: Consolidate ItemPointer to Datum conversion functions

2023-02-06 Thread Heikki Linnakangas
On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file. In passing, convert to inline functions. Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and PG_RETURN_ITEMPOINTER, too? They're

Consolidate ItemPointer to Datum conversion functions

2023-02-06 Thread Peter Eisentraut
] Consolidate ItemPointer to Datum conversion functions Instead of defining the same set of macros several times, define it once in an appropriate header file. In passing, convert to inline functions. --- contrib/pageinspect/btreefuncs.c | 2 -- contrib/pageinspect/ginfuncs.c | 3 --- contrib