On 2019-Jun-07, Amit Kapila wrote:
> Pushed. Note, I was not able to apply your patch using patch -p1 command.
Yeah, it's a "normal" diff (old school), not a unified or context diff.
patch doesn't like normal diff, for good reasons, but you can force it
to apply with "patch --normal" (not really
On Thu, Jun 6, 2019 at 8:12 AM Amit Kapila wrote:
>
> On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei wrote:
> >
> > Sorry, Last mail forget to CC the mailing list.
> >
> > Now the comment is confusing, Maybe someone should correct it.
> >
>
> Sure, for the sake of clarity, when this code was initially in
On Thu, Jun 6, 2019 at 7:37 AM Wu, Fei wrote:
>
> Sorry, Last mail forget to CC the mailing list.
>
> Now the comment is confusing, Maybe someone should correct it.
>
Sure, for the sake of clarity, when this code was initially introduced
in commit d1b7c1ff, the structure used was
SharedPlanStateI
To: Wu, Fei/吴 非
Cc: pgsql-hack...@postgresql.org
Subject: Re: Confusing comment for function ExecParallelEstimate
On Wed, Jun 5, 2019 at 11:27 AM Wu, Fei wrote:
>
> Thanks for your reply.
> From the code below:
> (https://github.com/postgres/postgres/blob/REL_10_7/src/backend
On Wed, Jun 5, 2019 at 11:27 AM Wu, Fei wrote:
>
> Thanks for your reply.
> From the code below:
> (https://github.com/postgres/postgres/blob/REL_10_7/src/backend/executor/execParallel.c)
> ###
> 443 /*
> 444
/* array of num_plan_nodes * num_workers Instrumentation objects
follows */
};
What do you think?
With Regards,
Wu Fei
-Original Message-
From: Amit Kapila [mailto:amit.kapil...@gmail.com]
Sent: Wednesday, June 05, 2019 12:20 PM
To: Wu, Fei/吴 非
Cc: pgsql-hack...@postgresql.org
Subjec
On Wed, Jun 5, 2019 at 9:24 AM Wu, Fei wrote:
>
> Hi, all
>
> Lately I was researching Parallelism of Postgres 10.7(and it is same in all
> version), and I was confused when reading the comment of function
> ExecParallelEstimate :
>
> (in src/backend/executor/execParallel.c)
>
> -
Hi, all
Lately I was researching Parallelism of Postgres 10.7(and it is same in all
version), and I was confused when reading the comment of function
ExecParallelEstimate :
(in src/backend/executor/execParallel.c)
--
* While we're at it, count the
