Re: Confused coding in PLy_traceback()

2025-06-01 Thread Tom Lane
I wrote: > So I propose the attached. For ease of review, I've not re-indented > the code that needs to move inside PG_TRY blocks. Also, I dropped the > logic about pfree'ing the string buffers in PLy_elog_impl's PG_FINALLY > block: that doesn't seem necessary, and continuing to do it would > req

Confused coding in PLy_traceback()

2025-05-31 Thread Tom Lane
My attention happened to be drawn to plpython's PLy_traceback() function, and I noted a couple of things that sure seem like bugs. First, there's this bit: e_type_o = PyObject_GetAttrString(e, "__name__"); e_module_o = PyObject_GetAttrString(e, "__module__"); if (e_type_o)