Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-19 Thread Marina Polyakova
On 2023-05-19 17:59, Tom Lane wrote: Marina Polyakova writes: On 2023-05-19 09:03, Michael Paquier wrote: FYI, the buildfarm is seeing some spurious failures as well: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=schnauzer&dt=2023-05-1904%3A29%3A42 Yes, it is the same error. Here'

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-19 Thread Tom Lane
Marina Polyakova writes: > On 2023-05-19 09:03, Michael Paquier wrote: >> FYI, the buildfarm is seeing some spurious failures as well: >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=schnauzer&dt=2023-05-1904%3A29%3A42 > Yes, it is the same error. Here's another one in version 13: > ht

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-18 Thread Marina Polyakova
On 2023-05-19 09:03, Michael Paquier wrote: On Wed, May 17, 2023 at 02:39:10PM +0900, Michael Paquier wrote: On Tue, May 16, 2023 at 11:02:45AM +0300, Marina Polyakova wrote: It confuses me a little that different methods are used for the same purpose. But the namespace test checks schemas. So

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-18 Thread Michael Paquier
On Wed, May 17, 2023 at 02:39:10PM +0900, Michael Paquier wrote: > On Tue, May 16, 2023 at 11:02:45AM +0300, Marina Polyakova wrote: >> It confuses me a little that different methods are used for the same >> purpose. But the namespace test checks schemas. So see >> diff_abc_to_txn_table.patch which

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-16 Thread Michael Paquier
On Tue, May 16, 2023 at 11:02:45AM +0300, Marina Polyakova wrote: > It confuses me a little that different methods are used for the same > purpose. But the namespace test checks schemas. So see > diff_abc_to_txn_table.patch which replaces abc with txn_table in the > transaction test. Looks OK seen

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-16 Thread Marina Polyakova
On 2023-05-16 02:19, Michael Paquier wrote: On Mon, May 15, 2023 at 11:23:18PM +0300, Marina Polyakova wrote: Maybe use a separate schema for all new objects in the transaction test?.. See diff_set_tx_schema.patch. Sure, you could do that to bypass the failure (without the "public" actually?)

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Tom Lane
Noah Misch writes: > For the record, I'm fairly sure s/public, test_ns_schema_1/test_ns_schema_1/ > on the new namespace tests would also solve things. Those tests don't need > "public" in the picture. Nonetheless, +1 for your proposal. Hmm, I'd not read the test case all that closely, but I di

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Noah Misch
On Mon, May 15, 2023 at 12:16:08PM -0400, Tom Lane wrote: > Marina Polyakova writes: > > IIUC the conflict was caused by > > > +SET search_path to public, test_ns_schema_1; > > +CREATE SCHEMA test_ns_schema_2 > > + CREATE VIEW abc_view AS SELECT a FROM abc; > > > because the parallel regre

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Michael Paquier
On Mon, May 15, 2023 at 11:23:18PM +0300, Marina Polyakova wrote: > On 2023-05-15 19:16, Tom Lane wrote: >> Hmm. I'd actually fix the blame on transactions.sql here. Creating >> a table named as generically as "abc" is horribly bad practice in >> a set of concurrent tests. namespace.sql is argua

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Marina Polyakova
On 2023-05-15 19:16, Tom Lane wrote: Marina Polyakova writes: IIUC the conflict was caused by +SET search_path to public, test_ns_schema_1; +CREATE SCHEMA test_ns_schema_2 + CREATE VIEW abc_view AS SELECT a FROM abc; because the parallel regression test transactions had already crea

Re: Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Tom Lane
Marina Polyakova writes: > IIUC the conflict was caused by > +SET search_path to public, test_ns_schema_1; > +CREATE SCHEMA test_ns_schema_2 > + CREATE VIEW abc_view AS SELECT a FROM abc; > because the parallel regression test transactions had already created > the table abc and was tryin

Conflict between regression tests namespace & transactions due to recent changes

2023-05-15 Thread Marina Polyakova
Hello, hackers! When running tests for version 15, we found a conflict between regression tests namespace & transactions due to recent changes [1]. diff -w -U3 .../src/test/regress/expected/transactions.out .../src/bin/pg_upgrade/tmp_check/results/transactions.out --- .../src/test/reg