Re: Condition variables vs interrupts

2020-01-27 Thread Thomas Munro
On Tue, Dec 24, 2019 at 3:10 PM Thomas Munro wrote: > On Sat, Dec 21, 2019 at 2:10 PM Shawn Debnath wrote: > > On Fri, Dec 20, 2019 at 12:05:34PM +1300, Thomas Munro wrote: > > > I think we should probably just remove the unusual ResetLatch() call, > > > rather than adding a CFI(). See attached.

Re: Condition variables vs interrupts

2019-12-23 Thread Thomas Munro
On Sat, Dec 21, 2019 at 2:10 PM Shawn Debnath wrote: > On Fri, Dec 20, 2019 at 12:05:34PM +1300, Thomas Munro wrote: > > I think we should probably just remove the unusual ResetLatch() call, > > rather than adding a CFI(). See attached. Thoughts? > > I agree: removing the ResetLatch() and having

Condition variables vs interrupts

2019-12-19 Thread Thomas Munro
Hi, While testing something unrelated, Tomas reported[1] that he could make a parallel worker ignore a SIGTERM and hang forever in ConditionVariableSleep(). I looked into this and realised that it's more likely in master. Commit 1321509f refactored the latch wait loop to look a little bit more l