Re: Compiling warnings on old GCC

2023-11-06 Thread Tom Lane
Richard Guo writes: > On Mon, Nov 6, 2023 at 2:51 PM David Rowley wrote: >> There's some relevant discussion in >> https://postgr.es/m/flat/20220602024243.GJ29853%40telsasoft.com > It seems that the controversial '-Og' coupled with the old GCC version > (4.8) makes it not worth fixing. So pleas

Re: Compiling warnings on old GCC

2023-11-05 Thread Richard Guo
On Mon, Nov 6, 2023 at 2:51 PM David Rowley wrote: > On Mon, 6 Nov 2023 at 19:14, Richard Guo wrote: > > I came across the following compiling warnings on GCC (Red Hat 4.8.5-44) > > 4.8.5 with 'CFLAGS=-Og' > > > I wonder if this is worth fixing, maybe by a trivial patch like > > attached. > > Th

Re: Compiling warnings on old GCC

2023-11-05 Thread David Rowley
On Mon, 6 Nov 2023 at 19:14, Richard Guo wrote: > I came across the following compiling warnings on GCC (Red Hat 4.8.5-44) > 4.8.5 with 'CFLAGS=-Og' > I wonder if this is worth fixing, maybe by a trivial patch like > attached. There's some relevant discussion in https://postgr.es/m/flat/20220602

Compiling warnings on old GCC

2023-11-05 Thread Richard Guo
I came across the following compiling warnings on GCC (Red Hat 4.8.5-44) 4.8.5 with 'CFLAGS=-Og' be-fsstubs.c: In function ‘be_lo_export’: be-fsstubs.c:537:24: warning: ‘fd’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (CloseTransientFile(fd) != 0)