Re: CompilerWarnings task does not catch C++ warnings

2024-06-18 Thread Andres Freund
Hi, On 2024-06-18 09:27:02 +0200, Peter Eisentraut wrote: > The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code. > It tries to make warnings fatal by passing COPT='-Werror', but that does not > apply to C++ compilations. > > I suggest that we just add COPT to CXXFLAGS as we

Re: CompilerWarnings task does not catch C++ warnings

2024-06-18 Thread Peter Eisentraut
On 18.06.24 16:08, Tom Lane wrote: Peter Eisentraut writes: The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code. It tries to make warnings fatal by passing COPT='-Werror', but that does not apply to C++ compilations. I suggest that we just add COPT to CXXFLAGS as well.

Re: CompilerWarnings task does not catch C++ warnings

2024-06-18 Thread Tom Lane
Peter Eisentraut writes: > The CompilerWarnings task on Cirrus CI does not catch warnings in C++ > code. It tries to make warnings fatal by passing COPT='-Werror', but > that does not apply to C++ compilations. > I suggest that we just add COPT to CXXFLAGS as well. I think passing > -Werror i

CompilerWarnings task does not catch C++ warnings

2024-06-18 Thread Peter Eisentraut
The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code. It tries to make warnings fatal by passing COPT='-Werror', but that does not apply to C++ compilations. I suggest that we just add COPT to CXXFLAGS as well. I think passing -Werror is just about the only reasonable u