Re: Compiler warnings with --enable-dtrace

2018-05-24 Thread Peter Geoghegan
On Wed, May 23, 2018 at 5:17 AM, Christoph Berg wrote: > I'm not aware of any guidelines - I guess this stuff is still too new > to make general statements about it. Which other software offers > custom probes? As the LWN article mentions, user space probes are available for a number of other wid

Re: Compiler warnings with --enable-dtrace

2018-05-23 Thread Christoph Berg
Re: Peter Geoghegan 2018-05-12 > Does Debian take any position on what packagers should do with USDT > probes in general? I'm not aware of any guidelines - I guess this stuff is still too new to make general statements about it. Which other software offers custom probes? Christoph

Re: Compiler warnings with --enable-dtrace

2018-05-13 Thread Thomas Munro
On Sun, May 13, 2018 at 8:40 AM, Peter Geoghegan wrote: > On Fri, May 11, 2018 at 11:46 PM, Christoph Berg wrote: >> Re: Peter Geoghegan 2018-05-12 >> >>> It seems to be surprisingly low overhead in many cases. >> >> I was pondering adding --enable-dtrace in the Debian packages, but I was init

Re: Compiler warnings with --enable-dtrace

2018-05-12 Thread Peter Geoghegan
On Fri, May 11, 2018 at 11:46 PM, Christoph Berg wrote: > Re: Peter Geoghegan 2018-05-12 > >> It seems to be surprisingly low overhead in many cases. > > I was pondering adding --enable-dtrace in the Debian packages, but > Andres advised against it, "because it affects code generation". > > So f

Re: Compiler warnings with --enable-dtrace

2018-05-11 Thread Christoph Berg
Re: Peter Geoghegan 2018-05-12 > It seems to be surprisingly low overhead in many cases. I was pondering adding --enable-dtrace in the Debian packages, but Andres advised against it, "because it affects code generation". So far, perf seems to be the tool of choice. Christoph

Re: Compiler warnings with --enable-dtrace

2018-05-11 Thread Peter Geoghegan
On Mon, May 7, 2018 at 9:42 AM, Tom Lane wrote: > Thomas Munro writes: >> --enable-dtrace produces compiler warnings about const correctness, >> except on macOS. That's because Apple's dtrace produces function >> declarations in probes.h that take strings as const char * whereas >> AFAIK on all

Re: Compiler warnings with --enable-dtrace

2018-05-11 Thread David Pacheco
On Sat, May 5, 2018 at 6:22 AM, Thomas Munro wrote: > Hi hackers, > > --enable-dtrace produces compiler warnings about const correctness, > except on macOS. That's because Apple's dtrace produces function > declarations in probes.h that take strings as const char * whereas > AFAIK on all other o

Re: Compiler warnings with --enable-dtrace

2018-05-07 Thread Tom Lane
I wrote: > Thomas Munro writes: >> Maybe we should do what the Perl people do[2] and post-process the >> generated header file to add const qualifiers? Please see attached. > +1 for the idea. I notice that Perl's version of this is careful > not to munge lines that already contain "const" ... d

Re: Compiler warnings with --enable-dtrace

2018-05-07 Thread Tom Lane
Thomas Munro writes: > --enable-dtrace produces compiler warnings about const correctness, > except on macOS. That's because Apple's dtrace produces function > declarations in probes.h that take strings as const char * whereas > AFAIK on all other operating systems they take char * (you can see >

Compiler warnings with --enable-dtrace

2018-05-05 Thread Thomas Munro
Hi hackers, --enable-dtrace produces compiler warnings about const correctness, except on macOS. That's because Apple's dtrace produces function declarations in probes.h that take strings as const char * whereas AFAIK on all other operating systems they take char * (you can see that possibly rece