Re: Compilation issue on Solaris.

2022-09-05 Thread Ibrar Ahmed
On Tue, Sep 6, 2022 at 9:24 AM John Naylor wrote: > On Sun, Jul 10, 2022 at 9:27 PM Tom Lane wrote: > > > > Thomas Munro writes: > > > Something bothers me about adding yet more clutter to every compile > > > line for the rest of time to solve a problem that exists only for > > > unpatched syst

Re: Compilation issue on Solaris.

2022-09-05 Thread John Naylor
On Sun, Jul 10, 2022 at 9:27 PM Tom Lane wrote: > > Thomas Munro writes: > > Something bothers me about adding yet more clutter to every compile > > line for the rest of time to solve a problem that exists only for > > unpatched systems, and also that it's not even really a Solaris thing, > > it'

Re: Compilation issue on Solaris.

2022-07-10 Thread Tom Lane
Thomas Munro writes: > Something bothers me about adding yet more clutter to every compile > line for the rest of time to solve a problem that exists only for > unpatched systems, and also that it's not even really a Solaris thing, > it's a C11 thing. I tend to agree with this standpoint: if it's

Re: Compilation issue on Solaris.

2022-07-09 Thread Thomas Munro
On Sun, Jul 10, 2022 at 5:47 AM Ibrar Ahmed wrote: > I am using "SunOS solaris-vagrant 5.11 11.4.0.15.0 i86pc i386 i86pc", Hah. So your vagrant image must be from a fairly narrow range of time when Solaris 11.4 came out with memset_s but didn't yet have explicit_bzero. That arrived in SRU12 in

Re: Compilation issue on Solaris.

2022-07-09 Thread Ibrar Ahmed
On Sat, Jul 9, 2022 at 10:28 AM Thomas Munro wrote: > On Sat, Jul 9, 2022 at 2:02 PM Ibrar Ahmed wrote: > > Thanks for looking at that, yes you are right, the attached patch do > that now > > > > if test "$PORTNAME" = "solaris"; then > > > >CPPFLAGS="$CPPFLAGS -D_POSIX_PTHREAD_SEMANTICS" >

Re: Compilation issue on Solaris.

2022-07-08 Thread Thomas Munro
On Sat, Jul 9, 2022 at 2:02 PM Ibrar Ahmed wrote: > Thanks for looking at that, yes you are right, the attached patch do that now > > if test "$PORTNAME" = "solaris"; then > >CPPFLAGS="$CPPFLAGS -D_POSIX_PTHREAD_SEMANTICS" > > + CPPFLAGS="$CPPFLAGS -D__STDC_WANT_LIB_EXT1__" > > fi Hmm. K.

Re: Compilation issue on Solaris.

2022-07-08 Thread Ibrar Ahmed
On Sat, Jul 9, 2022 at 6:46 AM Tom Lane wrote: > Ibrar Ahmed writes: > > While compiling the PostgreSQL I have found that *memset_s function > > requires a define "*__STDC_WANT_LIB_EXT1__*" * > > *explicit_bzero.c:* In function ‘*explicit_bzero*’: > > *explicit_bzero.c:23:9:* *warning: *implicit

Re: Compilation issue on Solaris.

2022-07-08 Thread Tom Lane
Ibrar Ahmed writes: > While compiling the PostgreSQL I have found that *memset_s function > requires a define "*__STDC_WANT_LIB_EXT1__*" * > *explicit_bzero.c:* In function ‘*explicit_bzero*’: > *explicit_bzero.c:23:9:* *warning: *implicit declaration of function ‘ > *memset_s*’; did you mean ‘*me

Compilation issue on Solaris.

2022-07-08 Thread Ibrar Ahmed
Hi, While compiling the PostgreSQL I have found that *memset_s function requires a define "*__STDC_WANT_LIB_EXT1__*" * *explicit_bzero.c:* In function ‘*explicit_bzero*’: *explicit_bzero.c:23:9:* *warning: *implicit declaration of function ‘ *memset_s*’; did you mean ‘*memset*’? [*-Wimplicit-fun