Re: Comment typo in tableam.h

2019-07-17 Thread Andres Freund
Hi, On 2019-07-11 20:44:02 -0500, Brad DeJong wrote: > More typos in tableam.h along with a few grammar changes. Thanks! Applied. Greetings, Andres Freund

Re: Comment typo in tableam.h

2019-07-11 Thread Brad DeJong
More typos in tableam.h along with a few grammar changes. v1-more-typos-in-tableam.h.patch Description: Binary data

Re: Comment typo in tableam.h

2019-07-10 Thread Amit Kapila
On Mon, Jul 8, 2019 at 10:21 PM Ashwin Agrawal wrote: > > > On Sat, Jul 6, 2019 at 12:05 AM Amit Kapila wrote: >> >> On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal wrote: >> > Please find attached v2 of patch 1 without objectionable comment change. >> > v1 of patch 2 attaching here just for conv

Re: Comment typo in tableam.h

2019-07-08 Thread Ashwin Agrawal
On Sat, Jul 6, 2019 at 12:05 AM Amit Kapila wrote: > On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal wrote: > > Please find attached v2 of patch 1 without objectionable comment change. > v1 of patch 2 attaching here just for convenience, no modifications made to > it. > > > > 0001* > * See table

Re: Comment typo in tableam.h

2019-07-06 Thread Amit Kapila
On Tue, Jul 2, 2019 at 1:00 AM Ashwin Agrawal wrote: > Please find attached v2 of patch 1 without objectionable comment change. v1 > of patch 2 attaching here just for convenience, no modifications made to it. > 0001* * See table_index_fetch_tuple's comment about what the difference between -

Re: Comment typo in tableam.h

2019-07-01 Thread Ashwin Agrawal
On Fri, Jun 28, 2019 at 1:47 PM Amit Kapila wrote: > On Mon, Jun 24, 2019 at 11:26 PM Ashwin Agrawal > wrote: > > > > On Mon, Jun 3, 2019 at 5:24 PM Ashwin Agrawal > wrote: > >> > >> There were few more minor typos I had collected for table am, passing > them along here. > >> > >> Some of the r

Re: Comment typo in tableam.h

2019-06-28 Thread Amit Kapila
On Mon, Jun 24, 2019 at 11:26 PM Ashwin Agrawal wrote: > > On Mon, Jun 3, 2019 at 5:24 PM Ashwin Agrawal wrote: >> >> There were few more minor typos I had collected for table am, passing them >> along here. >> >> Some of the required callback functions are missing Assert checking (minor >> thi

Re: Comment typo in tableam.h

2019-06-24 Thread Ashwin Agrawal
On Mon, Jun 3, 2019 at 5:24 PM Ashwin Agrawal wrote: > There were few more minor typos I had collected for table am, passing them > along here. > > Some of the required callback functions are missing Assert checking (minor > thing), adding them in separate patch. > Curious to know if need to reg

Re: Comment typo in tableam.h

2019-06-03 Thread Ashwin Agrawal
On Mon, Jun 3, 2019 at 6:24 PM Andres Freund wrote: > Hi, > > On 2019-06-03 18:21:56 -0700, Ashwin Agrawal wrote: > > On Mon, Jun 3, 2019 at 5:26 PM Andres Freund wrote: > > > > > Hi, > > > > > > Thanks for these! > > > > > > On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote: > > > > /* >

Re: Comment typo in tableam.h

2019-06-03 Thread Andres Freund
Hi, On 2019-06-03 18:21:56 -0700, Ashwin Agrawal wrote: > On Mon, Jun 3, 2019 at 5:26 PM Andres Freund wrote: > > > Hi, > > > > Thanks for these! > > > > On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote: > > > /* > > >* Estimate the size of shared memory needed for a parallel sca

Re: Comment typo in tableam.h

2019-06-03 Thread Ashwin Agrawal
On Mon, Jun 3, 2019 at 5:26 PM Andres Freund wrote: > Hi, > > Thanks for these! > > On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote: > > /* > >* Estimate the size of shared memory needed for a parallel scan > of this > > - * relation. The snapshot does not need to be account

Re: Comment typo in tableam.h

2019-06-03 Thread Andres Freund
Hi, Thanks for these! On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote: > /* >* Estimate the size of shared memory needed for a parallel scan of this > - * relation. The snapshot does not need to be accounted for. > + * relation. >*/ > Size(*par

Re: Comment typo in tableam.h

2019-06-03 Thread Ashwin Agrawal
There were few more minor typos I had collected for table am, passing them along here. Some of the required callback functions are missing Assert checking (minor thing), adding them in separate patch. From f32bdf5d0d3af5fd6ee6bf6430905f9c4bf5fefa Mon Sep 17 00:00:00 2001 From: Ashwin Agrawal Date

Re: Comment typo in tableam.h

2019-05-31 Thread David Rowley
On Fri, 31 May 2019 at 05:02, Antonin Houska wrote: > Please see the diff attached. Pushed. Thanks. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Comment typo in tableam.h

2019-05-31 Thread Antonin Houska
Please see the diff attached. -- Antonin Houska Web: https://www.cybertec-postgresql.com diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h index bf3a472018..e3619b8e7e 100644 --- a/src/include/access/tableam.h +++ b/src/include/access/tableam.h @@ -1331,7 +1331,7 @@ table_