Re: Comment in ginpostinglist.c doesn't match code

2019-08-28 Thread Heikki Linnakangas
On 23/08/2019 11:44, Masahiko Sawada wrote: On Fri, Aug 23, 2019 at 7:05 AM Ashwin Agrawal wrote: On Thu, Aug 22, 2019 at 1:14 AM Heikki Linnakangas wrote: The patch also includes a little unit test module to test this without creating a 16 TB table. A whole new test module seems a bit like

Re: Comment in ginpostinglist.c doesn't match code

2019-08-23 Thread Alexander Korotkov
On Thu, Aug 22, 2019 at 11:14 AM Heikki Linnakangas wrote: > While merging Greenplum with 9.4, we ran into problems with the GIN > posting list encoding, because Greenplum sometimes uses ItemPointers > with offset numbers up to 32768. The GIN posting list code was written > with the assumption tha

Re: Comment in ginpostinglist.c doesn't match code

2019-08-23 Thread Masahiko Sawada
On Fri, Aug 23, 2019 at 7:05 AM Ashwin Agrawal wrote: > > On Thu, Aug 22, 2019 at 1:14 AM Heikki Linnakangas wrote: >> >> >> The patch also includes a little unit test module to test this without >> creating a 16 TB table. A whole new test module seems a bit like >> overkill just for this, but cl

Re: Comment in ginpostinglist.c doesn't match code

2019-08-22 Thread Ashwin Agrawal
On Thu, Aug 22, 2019 at 1:14 AM Heikki Linnakangas wrote: > > The patch also includes a little unit test module to test this without > creating a 16 TB table. A whole new test module seems a bit like > overkill just for this, but clearly we were missing test coverage here. > And it will come hand

Comment in ginpostinglist.c doesn't match code

2019-08-22 Thread Heikki Linnakangas
Hi, While merging Greenplum with 9.4, we ran into problems with the GIN posting list encoding, because Greenplum sometimes uses ItemPointers with offset numbers up to 32768. The GIN posting list code was written with the assumption that the maximum is MaxHeapTuplesPerPage, and it uses only 11