Re: Comment explaining why vacuum needs to push snapshot seems insufficient.

2020-04-15 Thread Andres Freund
Hi, On 2020-04-15 17:56:58 -0400, Alvaro Herrera wrote: > On 2020-Apr-05, Andres Freund wrote: > > > vacuum_rel() has the following comment: > > /* > > * Functions in indexes may want a snapshot set. Also, setting a > > snapshot > > * ensures that RecentGlobalXmin is kept truly re

Re: Comment explaining why vacuum needs to push snapshot seems insufficient.

2020-04-15 Thread Alvaro Herrera
On 2020-Apr-05, Andres Freund wrote: > vacuum_rel() has the following comment: > /* >* Functions in indexes may want a snapshot set. Also, setting a > snapshot >* ensures that RecentGlobalXmin is kept truly recent. >*/ > PushActiveSnapshot(GetTransactionSnapsh

Comment explaining why vacuum needs to push snapshot seems insufficient.

2020-04-05 Thread Andres Freund
Hi, vacuum_rel() has the following comment: /* * Functions in indexes may want a snapshot set. Also, setting a snapshot * ensures that RecentGlobalXmin is kept truly recent. */ PushActiveSnapshot(GetTransactionSnapshot()); which was added quite a while