Re: Code review in dsa.c

HI, On Jan 16, 2023, 00:10 +0800, Nathan Bossart , wrote: > On Mon, Jan 16, 2023 at 12:04:56AM +0800, Zhang Mingli wrote: > > So, they are all dead codes, provide a patch to remove them. > > I am proposing a new use of dsa_create, dsa_attach, and dsa_get_handle in > https://commitfest.postgresql.o

Re: Code review in dsa.c

On Mon, Jan 16, 2023 at 12:04:56AM +0800, Zhang Mingli wrote: > So, they are all dead codes, provide a patch to remove them. I am proposing a new use of dsa_create, dsa_attach, and dsa_get_handle in https://commitfest.postgresql.org/41/4020/. These might also be useful for extensions, so IMHO we

Re: Code review in dsa.c

HI, On Jan 15, 2023, 23:43 +0800, Zhang Mingli , wrote: > Hi, hackers > > Found  some functions in dsa.c are not used anymore. > > dsa_create > dsa_attach > dsa_get_handle > dsa_trim > dsa_dump > > We once used dsa_create to create DSA and  it ’s all replaced by > dsa_create_in_place since commit

Code review in dsa.c

Hi, hackers Found  some functions in dsa.c are not used anymore. dsa_create dsa_attach dsa_get_handle dsa_trim dsa_dump We once used dsa_create to create DSA and  it ’s all replaced by dsa_create_in_place since commit 31ae1638ce. dsa_attach and dsa_get_handle cooperate with dsa_create. dsa_trim