Re: Code comment change

2019-07-01 Thread Peter Geoghegan
On Mon, Jul 1, 2019 at 7:28 PM Tom Lane wrote: > Even more interesting, the same para also exists verbatim in > v4r2's src/backend/access/nobtree/nobtpage.c, which is dated 1991-10-29 > in the same tarball. (If you're wondering, "nobtree" seems to stand > for "no-overwrite btree"; so I suppose it

Re: Code comment change

2019-07-01 Thread Tom Lane
Peter Geoghegan writes: > On Sun, Jun 23, 2019 at 3:36 AM Thomas Munro wrote: >> Pushed. Thanks! > I wonder what the comment is supposed to mean. > I think that it's addressing the situation prior to commit 70508ba7aed > in 2003, which was the point when the "fast" root concept was > introduced

Re: Code comment change

2019-07-01 Thread Peter Geoghegan
On Sun, Jun 23, 2019 at 3:36 AM Thomas Munro wrote: > Pushed. Thanks! I wonder what the comment is supposed to mean. I think that it's addressing the situation prior to commit 70508ba7aed in 2003, which was the point when the "fast" root concept was introduced. Prior to that commit, there was o

Re: Code comment change

2019-06-23 Thread Vik Fearing
On 23/06/2019 12:35, Thomas Munro wrote: > On Sun, Jun 23, 2019 at 9:21 PM Vik Fearing > wrote: >> There is some language in a code comment that has been bothering me for >> several years now. After pointing it out in a conversation off-list >> recently, I figured it was past time to do somethin

Re: Code comment change

2019-06-23 Thread Thomas Munro
On Sun, Jun 23, 2019 at 9:21 PM Vik Fearing wrote: > There is some language in a code comment that has been bothering me for > several years now. After pointing it out in a conversation off-list > recently, I figured it was past time to do something about it. > > Patch attached. Pushed. Thanks!

Code comment change

2019-06-23 Thread Vik Fearing
There is some language in a code comment that has been bothering me for several years now. After pointing it out in a conversation off-list recently, I figured it was past time to do something about it. Patch attached. -- Vik Fearing +33 6 46 75 15 36 htt