Re: ClosePipeStream failure ignored in pg_import_system_collations

2019-05-23 Thread Tom Lane
Mark Dilger writes: > On Thu, May 23, 2019 at 3:23 PM Tom Lane wrote: >> The concrete case where that's an issue, I think, is that "locale -a" >> fails, possibly after outputting a few locale names. The only report >> we get about that is a failure indication from ClosePipeStream. >> As things s

Re: ClosePipeStream failure ignored in pg_import_system_collations

2019-05-23 Thread Mark Dilger
On Thu, May 23, 2019 at 3:23 PM Tom Lane wrote: > > Mark Dilger writes: > > I only see three invocations of ClosePipeStream in the sources. > > In two of them, the return value is checked and an error is raised > > if it failed. In the third, the error (if any) is squashed. > > > I don't know if

Re: ClosePipeStream failure ignored in pg_import_system_collations

2019-05-23 Thread Tom Lane
Mark Dilger writes: > I only see three invocations of ClosePipeStream in the sources. > In two of them, the return value is checked and an error is raised > if it failed. In the third, the error (if any) is squashed. > I don't know if a pipe stream over "locale -a" could ever fail to > close, bu

ClosePipeStream failure ignored in pg_import_system_collations

2019-05-23 Thread Mark Dilger
Hackers, I only see three invocations of ClosePipeStream in the sources. In two of them, the return value is checked and an error is raised if it failed. In the third, the error (if any) is squashed. I don't know if a pipe stream over "locale -a" could ever fail to close, but it seems sensible t