Re: Clear empty space in a page.

2021-05-31 Thread Yura Sokolov
Hi, Andres Freund wrote 2021-05-31 00:07: Hi, On 2021-05-30 03:10:26 +0300, Yura Sokolov wrote: While this result is not directly applied to stock PostgreSQL, I believe page compression is important for full_page_writes with wal_compression enabled. And probably when PostgreSQL is used on fi

Re: Clear empty space in a page.

2021-05-30 Thread Andres Freund
Hi, On 2021-05-30 03:10:26 +0300, Yura Sokolov wrote: > While this result is not directly applied to stock PostgreSQL, I believe > page compression is important for full_page_writes with wal_compression > enabled. And probably when PostgreSQL is used on filesystem with > compression enabled (ZFS?)

Re: Clear empty space in a page.

2021-05-30 Thread Omar Kilani
Hi, I happened to be running some postgres on zfs on Linux/aarch64 tests and tested this patch. Kernel: 4.18.0-305.el8.aarch64 CPU: 16x3.0GHz Ampere Alta / Arm Neoverse N1 cores ZFS: 2.1.0-rc6 ZFS options: options spl spl_kmem_cache_slab_limit=65536 (see: https://github.com/openzfs/zfs/issues/12

Re: Clear empty space in a page.

2021-05-29 Thread Fabien COELHO
Hello Yura, didn't measure impact on raw performance yet. Must be done. There c/should be a guc to control this behavior if the performance impact is noticeable. -- Fabien.

Clear empty space in a page.

2021-05-29 Thread Yura Sokolov
pact. Sorry, didn't measure impact on raw performance yet. regards, Yura Sokolov aka funny_falconcommit 6abfcaeb87fcb396c5e2dccd434ce2511314ff76 Author: Yura Sokolov Date: Sun May 30 02:39:17 2021 +0300 Clear empty space in a page Write zeroes to just cleared